You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/29 04:18:36 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #11687: [Doc][Task Plugin] Put default task parameters in a new file
EricGao888 opened a new issue, #11687:
URL: https://github.com/apache/dolphinscheduler/issues/11687
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
* Currently we have the description for default task parameters in every task plugin, which is hard to maintain and could result in inconsistency. We may put it in one file for better maintainability.
* Besides, we could polish the description for default task parameters for better readability.
### Documentation Links
https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/guide/task/shell.html
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #11687:
URL: https://github.com/apache/dolphinscheduler/issues/11687#issuecomment-1233771462
Tha's great. But I think there are several issues that need to be discussed.
For example, not all task types use resource centers and have memory (CPU) limitations. What should we deal with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie closed issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
zhongjiajie closed issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
URL: https://github.com/apache/dolphinscheduler/issues/11687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11687:
URL: https://github.com/apache/dolphinscheduler/issues/11687#issuecomment-1229748020
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] davidzollo commented on issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
davidzollo commented on issue #11687:
URL: https://github.com/apache/dolphinscheduler/issues/11687#issuecomment-1234998687
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #11687:
URL: https://github.com/apache/dolphinscheduler/issues/11687#issuecomment-1233789889
> > Tha's great. But I think there are several issues that need to be discussed.
> > For example, not all task types use resource centers and have memory (CPU) limitations. What should we deal with it?
>
> We could write it in the following way:
>
> Here is a cheatsheet for default parameters of task plugins, each task plugin may have all or only _**SOME**_ of those default parameters: blah blah blah blah
>
> Then we put a link in each task plugin instruction doc to it.
+1 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11687:
URL: https://github.com/apache/dolphinscheduler/issues/11687#issuecomment-1233687456
@zhongjiajie WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #11687: [Doc][Task Plugin] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11687:
URL: https://github.com/apache/dolphinscheduler/issues/11687#issuecomment-1233775431
> Tha's great. But I think there are several issues that need to be discussed.
>
> For example, not all task types use resource centers and have memory (CPU) limitations. What should we deal with it?
We could write it in the following way:
Here is a cheatsheet for default parameters of task plugins, each task plugin may have all or only ***SOME*** of those default parameters: blah blah blah blah
Then we put a link in each task plugin instruction doc to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org