You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/02 16:50:50 UTC
[GitHub] [tvm] ashutosh-arm opened a new pull request #9638: Options to create test directory and print commands in AOT Test Runner
ashutosh-arm opened a new pull request #9638:
URL: https://github.com/apache/tvm/pull/9638
Support for user given path to untar the MLF and produce files needed by the AOT test runner. Added verbose mode to peek into the steps test runner follows. With this PR, it will print make commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on pull request #9638: Options to create test directory and print commands in AOT Test Runner
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on pull request #9638:
URL: https://github.com/apache/tvm/pull/9638#issuecomment-984810067
cc: @manupa-arm @grant-arm @mbaret @ekalda for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9638: Options to create test directory and print commands in AOT Test Runner
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9638:
URL: https://github.com/apache/tvm/pull/9638#issuecomment-988686089
Thanks! @ashutosh-arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm merged pull request #9638: Options to create test directory and print commands in AOT Test Runner
Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #9638:
URL: https://github.com/apache/tvm/pull/9638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on a change in pull request #9638: Options to create test directory and print commands in AOT Test Runner
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on a change in pull request #9638:
URL: https://github.com/apache/tvm/pull/9638#discussion_r763833333
##########
File path: tests/python/relay/aot/aot_test_utils.py
##########
@@ -772,7 +781,16 @@ def compile_and_run(
use_runtime_executor: bool = True,
target: str = "c",
target_opts: Dict = None,
+ test_dir: str = None,
+ verbose: bool = False,
):
+ """
+ Compiles the AOTTestModel and runs using AOT test runner
+ Parameters
+ ----------
+ test_dir : This path will contain build, codegen, include directories
Review comment:
Shall we use numpy style docstrings? Please refer to other python code in the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9638: Options to create test directory and print commands in AOT Test Runner
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on a change in pull request #9638:
URL: https://github.com/apache/tvm/pull/9638#discussion_r763845396
##########
File path: tests/python/relay/aot/aot_test_utils.py
##########
@@ -772,7 +781,16 @@ def compile_and_run(
use_runtime_executor: bool = True,
target: str = "c",
target_opts: Dict = None,
+ test_dir: str = None,
+ verbose: bool = False,
):
+ """
+ Compiles the AOTTestModel and runs using AOT test runner
+ Parameters
+ ----------
+ test_dir : This path will contain build, codegen, include directories
Review comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on pull request #9638: Options to create test directory and print commands in AOT Test Runner
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on pull request #9638:
URL: https://github.com/apache/tvm/pull/9638#issuecomment-988684856
@manupa-arm Could you please use the commit message: "Support for user given directory in AOT Test Runner"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org