You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/25 14:14:51 UTC
[GitHub] [airflow] potiuk opened a new pull request #15518: Adds interactivity when generating provider documentation.
potiuk opened a new pull request #15518:
URL: https://github.com/apache/airflow/pull/15518
The release manager, when reviewing providers to release might
make interactive decisions what to do:
1) mark certain provider as 'doc-only' change
2) decide whethere to generate documentation for the provider
In case the provider change is marked as 'doc-only' the next time
when providers are checked the doc-only change is not seen as
'change' and the provider is automatically skipped.
This saves time when preparing subsequent releases of providers
as all the "doc-only changes" from the previous release do not
have to be re-reviewed (unless there are some new changes).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#discussion_r622182580
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -125,21 +125,20 @@ def cli():
...
-@cli.resultcallback()
-def process_result(result):
- # This is special case - when the command executed returns false, it means that we are skipping
- # the package
- if result is False:
- raise click.exceptions.Exit(64)
- return result
-
-
option_git_update = click.option(
'--git-update/--no-git-update',
default=True,
is_flag=True,
help=f"If the git remote {HTTPS_REMOTE} already exists, don't try to update it",
)
+
+option_interactive = click.option(
+ '--interactive/--no-interactive',
Review comment:
Ah yeah Indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#discussion_r622138790
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -791,36 +804,38 @@ def convert_git_changes_to_table(
:param changes: list of changes in a form of multiple-line string
:param base_url: base url for the commit URL
:param markdown: if True, markdown format is used else rst
- :return: formatted table
+ :return: formatted table + list of changes (starting from the latest
Review comment:
Missing close bracket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#issuecomment-827925911
Hey @kaxil @ash - I'd love to release those few providers for PIP21 compatibility - this would be useful to have for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15518:
URL: https://github.com/apache/airflow/pull/15518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#discussion_r622181762
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -125,21 +125,20 @@ def cli():
...
-@cli.resultcallback()
-def process_result(result):
- # This is special case - when the command executed returns false, it means that we are skipping
- # the package
- if result is False:
- raise click.exceptions.Exit(64)
- return result
-
-
option_git_update = click.option(
'--git-update/--no-git-update',
default=True,
is_flag=True,
help=f"If the git remote {HTTPS_REMOTE} already exists, don't try to update it",
)
+
+option_interactive = click.option(
+ '--interactive/--no-interactive',
Review comment:
I am afraid this is not how click works :( https://click.palletsprojects.com/en/7.x/options/#boolean-flags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#discussion_r622138505
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -125,21 +125,20 @@ def cli():
...
-@cli.resultcallback()
-def process_result(result):
- # This is special case - when the command executed returns false, it means that we are skipping
- # the package
- if result is False:
- raise click.exceptions.Exit(64)
- return result
-
-
option_git_update = click.option(
'--git-update/--no-git-update',
default=True,
is_flag=True,
help=f"If the git remote {HTTPS_REMOTE} already exists, don't try to update it",
)
+
+option_interactive = click.option(
+ '--interactive/--no-interactive',
Review comment:
```suggestion
'--interactive/--non-interactive',
```
Worth changing `--no-interactive` to `non-interactive` everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#issuecomment-828486520
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#issuecomment-828461287
All Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15518: Adds interactivity when generating provider documentation.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15518:
URL: https://github.com/apache/airflow/pull/15518#discussion_r622139020
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -791,36 +804,38 @@ def convert_git_changes_to_table(
:param changes: list of changes in a form of multiple-line string
:param base_url: base url for the commit URL
:param markdown: if True, markdown format is used else rst
- :return: formatted table
+ :return: formatted table + list of changes (starting from the latest
Review comment:
```suggestion
:return: formatted table + list of changes (starting from the latest)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org