[jira] Closed: (GERONIMO-1336) Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails

["Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>]

     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]
     
Matt Hogstrom closed GERONIMO-1336:
-----------------------------------

    Resolution: Fixed

branches/1.0

svn commit -m "Geronimo-1336 Corrected issue when specifying database pool sizes"   
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/confirmURL.jsp
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/edit.jsp
Transmitting file data ..
Committed revision 374252.


trunk

svn commit -m "Geronimo-1336 Corrected issue when specifying database pool sizes"
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/confirmURL.jsp
Sending        applications/console-standard/src/webapp/WEB-INF/view/dbwizard/edit.jsp
Transmitting file data ..
Committed revision 374253.


> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Matt Hogstrom
>     Priority: Minor
>      Fix For: 1.0.1, 1.1
>  Attachments: DBPoolValidate.patch, DBPoolValidate2.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira