You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/08/18 08:13:15 UTC
[jira] Commented: (ZOOKEEPER-849) Provide Path class
[ https://issues.apache.org/jira/browse/ZOOKEEPER-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899750#action_12899750 ]
Patrick Hunt commented on ZOOKEEPER-849:
----------------------------------------
Hi Thomas, in general this looks good to me, a good idea as well!
some comments:
1) the javadoc, esp for the constructor, more is needed imo.
2) for example, what does "isSequential" mean? Why are we leaving this designation up to the caller? (I realize it's a concept from the old code, is there a way to make this better?)
3) Update the forrest docs while you're at it - esp around making it explicit what's a valid path and what's not. Per your point earlier about what's correct - you might start a discussion on zookeeper-dev about this?
feel free to post your reviews up on reviewboard: https://review.cloudera.org/groups/zookeeper/
hbase seems to be having good luck with this. Only thing is we should really capture the final comments (and obv the patch itself) here on the jira.
> Provide Path class
> ------------------
>
> Key: ZOOKEEPER-849
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-849
> Project: Zookeeper
> Issue Type: Sub-task
> Components: java client
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-849.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.