You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/08/08 21:17:31 UTC
Review Request 61507: GEODE-3313: Test utility supports building jar files with multiple classes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61507/
-----------------------------------------------------------

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
-------

GEODE-3383: Refactor deploy tests

- Remove some duplicated tests
- Re-organize some tests
- DeployedJarJUnitTest now tests the public api of that class rather than implementation details


Diffs
-----

  geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java 34d8a2318422edbb3bbdc04920a41693f8d3fe69 
  geode-core/src/test/java/org/apache/geode/internal/DeployedJarJUnitTest.java 178dbae2eaada0cc054502fdf4b6d2ff102b4ed6 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDeadlockTest.java PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/DeployJarTestSuite.java 6dfab66926c7b246bf839632b293330959f1d728 
  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java 89148d7752ae1f69e25671ffc43101a63cf7dc64 
  geode-junit/build.gradle e47095f5c538c4ae040b7135bf20eeef55bd77ba 
  geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java PRE-CREATION 
  geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java PRE-CREATION 
  geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java PRE-CREATION 
  geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java PRE-CREATION 
  geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java PRE-CREATION 
  geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java PRE-CREATION 
  geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java PRE-CREATION 
  geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java PRE-CREATION 
  geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java PRE-CREATION 
  geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractClass.java PRE-CREATION 
  geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteClass.java PRE-CREATION 
  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java 7753aafbd7dc5ea4288e27f088400163f6739347 


Diff: https://reviews.apache.org/r/61507/diff/1/


Testing
-------


Thanks,

Jared Stewart