You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/11 09:53:28 UTC

[GitHub] [airflow] kazanzhy commented on a change in pull request #20212: Fix MyPy Errors for provider

kazanzhy commented on a change in pull request #20212:
URL: https://github.com/apache/airflow/pull/20212#discussion_r767136297



##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -135,7 +137,7 @@ def __init__(self, *args, **kwargs) -> None:
         self.schema = kwargs.pop("schema", None)
         self.authenticator = kwargs.pop("authenticator", None)
         self.session_parameters = kwargs.pop("session_parameters", None)
-        self.query_ids = []
+        self.query_ids: List[str] = []

Review comment:
       I assume that in `run()` method this statement resets the list with ids.
   So it keeps just last run ids. I think that's reasonable




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org