You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2017/07/07 22:39:33 UTC
spark git commit: [SPARK-21336] Revise rand comparison in
BatchEvalPythonExecSuite
Repository: spark
Updated Branches:
refs/heads/master fbbe37ed4 -> a0fe32a21
[SPARK-21336] Revise rand comparison in BatchEvalPythonExecSuite
## What changes were proposed in this pull request?
Revise rand comparison in BatchEvalPythonExecSuite
In BatchEvalPythonExecSuite, there are two cases using the case "rand() > 3"
Rand() generates a random value in [0, 1), it is wired to be compared with 3, use 0.3 instead
## How was this patch tested?
unit test
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: Wang Gengliang <lt...@gmail.com>
Closes #18560 from gengliangwang/revise_BatchEvalPythonExecSuite.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/a0fe32a2
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/a0fe32a2
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/a0fe32a2
Branch: refs/heads/master
Commit: a0fe32a219253f0abe9d67cf178c73daf5f6fcc1
Parents: fbbe37e
Author: Wang Gengliang <lt...@gmail.com>
Authored: Fri Jul 7 15:39:29 2017 -0700
Committer: gatorsmile <ga...@gmail.com>
Committed: Fri Jul 7 15:39:29 2017 -0700
----------------------------------------------------------------------
.../spark/sql/execution/python/BatchEvalPythonExecSuite.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/a0fe32a2/sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
index 80ef4eb..bbd9484 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala
@@ -65,7 +65,7 @@ class BatchEvalPythonExecSuite extends SparkPlanTest with SharedSQLContext {
test("Python UDF: no push down on non-deterministic") {
val df = Seq(("Hello", 4)).toDF("a", "b")
- .where("b > 4 and dummyPythonUDF(a) and rand() > 3")
+ .where("b > 4 and dummyPythonUDF(a) and rand() > 0.3")
val qualifiedPlanNodes = df.queryExecution.executedPlan.collect {
case f @ FilterExec(
And(_: AttributeReference, _: GreaterThan),
@@ -77,7 +77,7 @@ class BatchEvalPythonExecSuite extends SparkPlanTest with SharedSQLContext {
test("Python UDF: no push down on predicates starting from the first non-deterministic") {
val df = Seq(("Hello", 4)).toDF("a", "b")
- .where("dummyPythonUDF(a) and rand() > 3 and b > 4")
+ .where("dummyPythonUDF(a) and rand() > 0.3 and b > 4")
val qualifiedPlanNodes = df.queryExecution.executedPlan.collect {
case f @ FilterExec(And(_: And, _: GreaterThan), InputAdapter(_: BatchEvalPythonExec)) => f
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org