[jira] [Commented] (METRON-1416) Upgrade Solr

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520527#comment-16520527 ] 

ASF GitHub Bot commented on METRON-1416:
----------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/1076

    METRON-1416: Upgrade Solr

    ## Contributor Comments
    Per the discussion [dev discussion](https://lists.apache.org/thread.html/1df267d5b192a304bb745221beb7a6edb6b05d25d0e857f4a53f55aa@%3Cdev.metron.apache.org%3E), seems like we're pretty set up on merging the Solr feature branch back to master.  That discussion also has the status of the feature branch
    
    In terms of testing, the individual Jiras at [METRON-1416](https://issues.apache.org/jira/browse/METRON-1416), have been tested and they should have appropriate test plans attached. Elasticsearch should work the same way as in master.
    
    If we need more detail on testing plans, we can go through and compile everything together.
    
    Documentation has been added discussing how to set up Solr.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron feature/METRON-1416-upgrade-solr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1076.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1076
    
----

----


> Upgrade Solr
> ------------
>
>                 Key: METRON-1416
>                 URL: https://issues.apache.org/jira/browse/METRON-1416
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Justin Leet
>            Priority: Major
>
> From the discussion thread:
>  
> Now that we have ES at a modern version, we should consider bringing Solr to a modern version as well.
>  
> The focus of this work would be to get us in a place where Solr is upgraded, along with the related work of building out the Solr functionality to parity with Elasticsearch. The goal would not be to add net new functionality, just to get Solr and ES in the same place for the alerts UI and REST interface.  Additionally, it would include the various supporting necessities such as ensuring associated DAOs are testable, and so on.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)