You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Cyrill (via GitHub)" <gi...@apache.org> on 2025/02/12 11:11:03 UTC
[PR] IGNITE-24410 Implement filters and manual reset integration tests for HA [ignite-3]
Cyrill opened a new pull request, #5219:
URL: https://github.com/apache/ignite-3/pull/5219
https://issues.apache.org/jira/browse/IGNITE-24410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24410 Implement filters and manual reset integration tests for HA [ignite-3]
Posted by "Cyrill (via GitHub)" <gi...@apache.org>.
Cyrill commented on code in PR #5219:
URL: https://github.com/apache/ignite-3/pull/5219#discussion_r1954564024
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/distributed/disaster/AbstractHighAvailablePartitionsRecoveryTest.java:
##########
@@ -506,4 +506,28 @@ private static Row marshalKey(TableViewInternal table, Tuple key) {
private static boolean isPrimaryReplicaHasChangedException(IgniteException cause) {
return ExceptionUtils.extractCodeFrom(cause) == Replicator.REPLICA_MISS_ERR;
}
+
+ void setDistributionResetTimeout(IgniteImpl node, long timeout) {
+ CompletableFuture<Void> changeFuture = node
+ .clusterConfiguration()
+ .getConfiguration(SystemDistributedExtensionConfiguration.KEY)
+ .system().change(c0 -> c0.changeProperties()
+ .createOrUpdate(PARTITION_DISTRIBUTION_RESET_TIMEOUT,
+ c1 -> c1.changePropertyValue(String.valueOf(timeout)))
+ );
+
+ assertThat(changeFuture, willCompleteSuccessfully());
+ }
+
+ void triggerManualReset(IgniteImpl node) {
+ CompletableFuture<?> updateFuture = node.disasterRecoveryManager().resetAllPartitions(
+ HA_ZONE_NAME,
+ SCHEMA_NAME,
+ HA_TABLE_NAME,
+ true,
+ 0
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24410 Implement filters and manual reset integration tests for HA [ignite-3]
Posted by "Cyrill (via GitHub)" <gi...@apache.org>.
Cyrill commented on code in PR #5219:
URL: https://github.com/apache/ignite-3/pull/5219#discussion_r1954562328
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerFilterTest.java:
##########
@@ -116,9 +117,14 @@ private void preparePrerequisites() throws Exception {
topology.putNode(B);
topology.putNode(C);
- createZone(ZONE_NAME, IMMEDIATE_TIMER_VALUE, IMMEDIATE_TIMER_VALUE, filter, null, DEFAULT_STORAGE_PROFILE);
+ createZone(ZONE_NAME, IMMEDIATE_TIMER_VALUE, IMMEDIATE_TIMER_VALUE, filter, consistencyMode(), DEFAULT_STORAGE_PROFILE);
assertDataNodesFromManager(distributionZoneManager, metaStorageManager::appliedRevision, catalogManager::latestCatalogVersion,
getZoneId(ZONE_NAME), Set.of(A, C), ZONE_MODIFICATION_AWAIT_TIMEOUT);
}
+
+
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24410 Implement filters and manual reset integration tests for HA [ignite-3]
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #5219:
URL: https://github.com/apache/ignite-3/pull/5219#discussion_r1954492082
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/distributed/disaster/AbstractHighAvailablePartitionsRecoveryTest.java:
##########
@@ -506,4 +506,28 @@ private static Row marshalKey(TableViewInternal table, Tuple key) {
private static boolean isPrimaryReplicaHasChangedException(IgniteException cause) {
return ExceptionUtils.extractCodeFrom(cause) == Replicator.REPLICA_MISS_ERR;
}
+
+ void setDistributionResetTimeout(IgniteImpl node, long timeout) {
+ CompletableFuture<Void> changeFuture = node
+ .clusterConfiguration()
+ .getConfiguration(SystemDistributedExtensionConfiguration.KEY)
+ .system().change(c0 -> c0.changeProperties()
+ .createOrUpdate(PARTITION_DISTRIBUTION_RESET_TIMEOUT,
+ c1 -> c1.changePropertyValue(String.valueOf(timeout)))
+ );
+
+ assertThat(changeFuture, willCompleteSuccessfully());
+ }
+
+ void triggerManualReset(IgniteImpl node) {
+ CompletableFuture<?> updateFuture = node.disasterRecoveryManager().resetAllPartitions(
+ HA_ZONE_NAME,
+ SCHEMA_NAME,
+ HA_TABLE_NAME,
+ true,
+ 0
Review Comment:
why 0? for manual reset it -1, according to javadoc
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerFilterTest.java:
##########
@@ -116,9 +117,14 @@ private void preparePrerequisites() throws Exception {
topology.putNode(B);
topology.putNode(C);
- createZone(ZONE_NAME, IMMEDIATE_TIMER_VALUE, IMMEDIATE_TIMER_VALUE, filter, null, DEFAULT_STORAGE_PROFILE);
+ createZone(ZONE_NAME, IMMEDIATE_TIMER_VALUE, IMMEDIATE_TIMER_VALUE, filter, consistencyMode(), DEFAULT_STORAGE_PROFILE);
assertDataNodesFromManager(distributionZoneManager, metaStorageManager::appliedRevision, catalogManager::latestCatalogVersion,
getZoneId(ZONE_NAME), Set.of(A, C), ZONE_MODIFICATION_AWAIT_TIMEOUT);
}
+
+
Review Comment:
redundant line
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/distributed/disaster/ItHighAvailablePartitionsRecoveryByFilterUpdateTest.java:
##########
@@ -126,6 +140,100 @@ private void alterZoneSql(String filter, String zoneName) {
executeSql(String.format("ALTER ZONE \"%s\" SET \"DATA_NODES_FILTER\" = '%s'", zoneName, filter));
}
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-24467")
+ @Test
+ void testResetAfterChangeFilters() throws InterruptedException {
Review Comment:
Here and for all newly added tests: let's add steps from the doc to the javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24410 Implement filters and manual reset integration tests for HA [ignite-3]
Posted by "Cyrill (via GitHub)" <gi...@apache.org>.
Cyrill commented on code in PR #5219:
URL: https://github.com/apache/ignite-3/pull/5219#discussion_r1954586144
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/distributed/disaster/ItHighAvailablePartitionsRecoveryByFilterUpdateTest.java:
##########
@@ -126,6 +140,100 @@ private void alterZoneSql(String filter, String zoneName) {
executeSql(String.format("ALTER ZONE \"%s\" SET \"DATA_NODES_FILTER\" = '%s'", zoneName, filter));
}
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-24467")
+ @Test
+ void testResetAfterChangeFilters() throws InterruptedException {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24410 Implement filters and manual reset integration tests for HA [ignite-3]
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #5219:
URL: https://github.com/apache/ignite-3/pull/5219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org