You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gharris1727 (via GitHub)" <gi...@apache.org> on 2023/05/30 15:51:29 UTC
[GitHub] [kafka] gharris1727 opened a new pull request, #13781: KAFKA-8713: JsonConverter replace.null.with.default should apply to Struct fields
gharris1727 opened a new pull request, #13781:
URL: https://github.com/apache/kafka/pull/13781
The "replace.null.with.default" option is a KIP-581 addition that is intended to (when false) prevent the Connect default values from being emitted in the JsonConverter. The current implementation works for root values, but does not work for Structs, as the Struct::get implementation has logic to substitute the default value if no value is present.
Instead, the JsonConverter should call Struct::getWithoutDefault, and hide the default value for Struct fields when "replace.null.with.default" is false.
This should be backported to 3.5
Supersedes #13748
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gharris1727 commented on pull request #13781: KAFKA-8713: JsonConverter replace.null.with.default should apply to Struct fields
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #13781:
URL: https://github.com/apache/kafka/pull/13781#issuecomment-1568679591
cc @mimaison @C0urante @krespo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #13781: KAFKA-8713: JsonConverter replace.null.with.default should apply to Struct fields
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #13781:
URL: https://github.com/apache/kafka/pull/13781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org