You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2025/11/30 07:59:37 UTC

[PR] [GH-2503] Switch to `prek` using `uv` [sedona]

jbampton opened a new pull request, #2542:
URL: https://github.com/apache/sedona/pull/2542

   Hit this issue:
   
   https://github.com/j178/prek/issues/987
   
   So disabled the "Go" based hook for now.
   
   Got the version of `astral-sh/setup-uv` from here:
   
   https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2503 
   
   ## What changes were proposed in this PR?
   
   The Makefile has some code comments.  If you are using `uv` then this is not new ground.
   
   ## How was this patch tested?
   
   Ran the targets in the Makefile.
   
   But also tested the `uv` and `prek` commands on their own.
   
   The Makefile is really just for convenience.
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-2503] Switch to `prek` using `uv` [sedona]

Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #2542:
URL: https://github.com/apache/sedona/pull/2542#issuecomment-4488136074

   Changes to use the ASF approved prek-action:
   
   https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
   
   https://prek.j178.dev/
   
   https://github.com/j178/prek-action/releases/tag/v2.0.3
   
   https://github.com/apache/infrastructure-actions/blob/976304ac0e90a8f80ebcf7ffe1de32f9478fded5/approved_patterns.yml#L194
   
   Added some documentation and updated the Makefile.
   
   Using prek and uv this PR enhances our workflow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-2503] Switch to `prek` using `uv` [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2542:
URL: https://github.com/apache/sedona/pull/2542


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org