You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/09/19 23:39:51 UTC
[GitHub] junichi11 commented on a change in pull request #889:
[NETBEANS-946] PHP 7.3 support (Flexible Heredoc and Nowdoc Syntaxes)
junichi11 commented on a change in pull request #889: [NETBEANS-946] PHP 7.3 support (Flexible Heredoc and Nowdoc Syntaxes)
URL: https://github.com/apache/incubator-netbeans/pull/889#discussion_r218997254
##########
File path: php/php.editor/test/unit/data/goldenfiles/org/netbeans/modules/php/editor/lexer/PHP53FeaturesTest/lexer/heredoc_001.pass
##########
@@ -11,27 +11,29 @@ token #9 WHITESPACE
token #10 PHP_HEREDOC_TAG_START <<<ENDOFHEREDOC\n
token #11 PHP_CONSTANT_ENCAPSED_STRING This is a heredoc test.
token #12 PHP_CONSTANT_ENCAPSED_STRING \n
-token #13 PHP_HEREDOC_TAG_END \nENDOFHEREDOC
-token #14 PHP_SEMICOLON ;
-token #15 WHITESPACE \n\n
-token #16 PHP_VARIABLE $x
-token #17 WHITESPACE
-token #18 PHP_OPERATOR =
-token #19 WHITESPACE
-token #20 PHP_HEREDOC_TAG_START <<<ENDOFHEREDOC\n
-token #21 PHP_CONSTANT_ENCAPSED_STRING This is another heredoc test.
-token #22 PHP_CONSTANT_ENCAPSED_STRING \n
-token #23 PHP_HEREDOC_TAG_END \nENDOFHEREDOC
-token #24 PHP_SEMICOLON ;
-token #25 WHITESPACE \n\n
-token #26 PHP_PRINT print
-token #27 WHITESPACE
-token #28 PHP_CONSTANT_ENCAPSED_STRING "
-token #29 PHP_CURLY_OPEN {
-token #30 PHP_VARIABLE $x
-token #31 PHP_CURLY_CLOSE }
-token #32 PHP_CONSTANT_ENCAPSED_STRING "
-token #33 PHP_SEMICOLON ;
-token #34 WHITESPACE \n\n
-token #35 PHP_CLOSETAG ?>
-token #36 T_INLINE_HTML \n--EXPECT--\nThis is a heredoc test.\nThis is another heredoc test.\n
+token #13 PHP_CONSTANT_ENCAPSED_STRING \n
+token #14 PHP_HEREDOC_TAG_END ENDOFHEREDOC
Review comment:
Move `\n` from `PHP_HEREDOC_TAG_END` to `PHP_CONSTANT_ENCAPSED_STRING`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists