You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/01 15:12:15 UTC
[GitHub] [airflow] kaxil opened a new pull request #9612: Restrict editing DagRun State in the old UI
kaxil opened a new pull request #9612:
URL: https://github.com/apache/airflow/pull/9612
Restrict editing DagRun State in the old UI
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9612: Restrict editing DagRun State in the old UI
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9612:
URL: https://github.com/apache/airflow/pull/9612#discussion_r448471527
##########
File path: UPDATING.md
##########
@@ -66,6 +66,14 @@ https://developers.google.com/style/inclusive-documentation
Now use NULL as default value for dag.description in dag table
+### Restrict editing DagRun State in the old UI (Flask-admin based UI)
+
+Before 1.10.11 it was possible to edit DagRun State in the `/admin/dagrun/` page
+ to any text.
+
+From Airflow 1.10.11, you would still be able to set from dropdown to a pre-defined option
+ but would not allow setting it to any text.
Review comment:
```suggestion
Before 1.10.11 it was possible to edit DagRun State in the `/admin/dagrun/` page
to any text.
In Airflow 1.10.11+, the user can only choose the states from the list.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9612: Restrict editing DagRun State in the old UI
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9612:
URL: https://github.com/apache/airflow/pull/9612#discussion_r448433288
##########
File path: UPDATING.md
##########
@@ -66,6 +66,14 @@ https://developers.google.com/style/inclusive-documentation
Now use NULL as default value for dag.description in dag table
+### Restrict editing DagRun State in the old UI (Flask-admin based UI)
+
+Before 1.10.11 it was possible to edit DagRun State in the `/admin/dagrun/` page
+ to any text.
+
+From Airflow 1.10.11, you would still be able to set from dropdown to a pre-defined option
+ but would not allow setting it to any text.
Review comment:
I don't like the wording though, can you help me with that Ash?
I can include screenshots if that is more helpful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #9612: Restrict editing DagRun State in the old UI
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #9612:
URL: https://github.com/apache/airflow/pull/9612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org