[GitHub] [druid] jihoonson commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegmentsManager

[GitBox <gi...@apache.org>]

jihoonson commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegmentsManager
URL: https://github.com/apache/druid/pull/7306#issuecomment-578910221
 
 
   [The line where LGTM complains about](https://lgtm.com/projects/g/apache/druid/snapshot/1eccddf3148290fc65705dc30841a69a010e8418/files/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Tasks.java?sort=name&dir=ASC&mode=heatmap#x6589eaaaae057834:1) is to verify two static variables have the same value which should have been the same variable but stored separately because of the module dependency. So, the LGTM failure doesn't look legit in this case. I'm not sure whether we can skip the LGTM inspection for some particular lines. I'm merging this PR since it has been open for too long time. We can address this issue later in a follow-up PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org