You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Kishor Gollapalliwar <ki...@gmail.com> on 2020/10/23 04:58:04 UTC

Re: Review Request 72984: RANGER-3057: Support Audit search based on Audit ID

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72984/
-----------------------------------------------------------

(Updated Oct. 23, 2020, 4:58 a.m.)


Review request for ranger, Dineshkumar Yadav, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3057
    https://issues.apache.org/jira/browse/RANGER-3057


Repository: ranger


Description
-------

Add Audit ID as a filter to search Access Audits.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java fd6e738c8 
  security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java f3c6e3fbc 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 16b70f4d1 


Diff: https://reviews.apache.org/r/72984/diff/1/


Testing
-------

maven build
verified Access Audit page with and without "Audit ID" filter.


Thanks,

Kishor Gollapalliwar


Re: Review Request 72984: RANGER-3057: Support Audit search based on Audit ID

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72984/#review222128
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Oct. 26, 2020, 12:43 p.m., Kishor Gollapalliwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72984/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2020, 12:43 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3057
>     https://issues.apache.org/jira/browse/RANGER-3057
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add Audit ID as a filter to search Access Audits.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java fd6e738c8 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java f3c6e3fbc 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 16b70f4d1 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java c4844cf31 
> 
> 
> Diff: https://reviews.apache.org/r/72984/diff/2/
> 
> 
> Testing
> -------
> 
> maven build
> verified Access Audit page with and without "Audit ID" filter.
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>


Re: Review Request 72984: RANGER-3057: Support Audit search based on Audit ID

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72984/#review222126
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 26, 2020, 12:43 p.m., Kishor Gollapalliwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72984/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2020, 12:43 p.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3057
>     https://issues.apache.org/jira/browse/RANGER-3057
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add Audit ID as a filter to search Access Audits.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java fd6e738c8 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java f3c6e3fbc 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 16b70f4d1 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java c4844cf31 
> 
> 
> Diff: https://reviews.apache.org/r/72984/diff/2/
> 
> 
> Testing
> -------
> 
> maven build
> verified Access Audit page with and without "Audit ID" filter.
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>


Re: Review Request 72984: RANGER-3057: Support Audit search based on Audit ID

Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72984/
-----------------------------------------------------------

(Updated Oct. 26, 2020, 12:43 p.m.)


Review request for ranger, Dineshkumar Yadav, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Fixed test cases, caused by the change


Bugs: RANGER-3057
    https://issues.apache.org/jira/browse/RANGER-3057


Repository: ranger


Description
-------

Add Audit ID as a filter to search Access Audits.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java fd6e738c8 
  security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java f3c6e3fbc 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 16b70f4d1 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java c4844cf31 


Diff: https://reviews.apache.org/r/72984/diff/2/

Changes: https://reviews.apache.org/r/72984/diff/1-2/


Testing
-------

maven build
verified Access Audit page with and without "Audit ID" filter.


Thanks,

Kishor Gollapalliwar