You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2011/06/01 12:53:47 UTC

[jira] [Created] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

zookeeper test jar has non mavenised dependency.
------------------------------------------------

                 Key: ZOOKEEPER-1086
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
             Project: ZooKeeper
          Issue Type: Bug
            Reporter: Ivan Kelly
            Assignee: Ivan Kelly


The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Koch reopened ZOOKEEPER-1086:
------------------------------------


The accessive.jar is still in SVN under src/java/libtest/accessive.jar. Please remove it, if it's not needed anymore.
I've also contacted the author of accessive and mavenized the project with him. It should be available soon, if you still need it.

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-1086:
-------------------------------------

    Hadoop Flags: [Reviewed]

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130510#comment-13130510 ] 

Hudson commented on ZOOKEEPER-1086:
-----------------------------------

Integrated in ZooKeeper-trunk #1337 (See [https://builds.apache.org/job/ZooKeeper-trunk/1337/])
    ZOOKEEPER-1086. zookeeper test jar has non mavenised dependency.

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185994
Files : 
* /zookeeper/trunk/src/java/libtest/accessive.jar

                
> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated ZOOKEEPER-1086:
----------------------------------

    Attachment: ZOOKEEPER-1086.diff

Simple solution is to ship accessive.jar contents and license inside zookeeper test jar.

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Mahadev konar (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar resolved ZOOKEEPER-1086.
--------------------------------------

    Resolution: Fixed

Just removed the jars. Thanks Thomas for pointing out.
                
> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042314#comment-13042314 ] 

Ivan Kelly commented on ZOOKEEPER-1086:
---------------------------------------

This is also a possibility. I've attached a patch that removes accessive.jar. You guys can vote on which approach you prefer.

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045553#comment-13045553 ] 

Benjamin Reed commented on ZOOKEEPER-1086:
------------------------------------------

+1 looks good.

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042328#comment-13042328 ] 

Hadoop QA commented on ZOOKEEPER-1086:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481118/ZOOKEEPER-1086.diff
  against trunk revision 1125581.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/304//console

This message is automatically generated.

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated ZOOKEEPER-1086:
----------------------------------

    Attachment: ZOOKEEPER-1086.diff

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050967#comment-13050967 ] 

Hudson commented on ZOOKEEPER-1086:
-----------------------------------

Integrated in ZooKeeper-trunk #1215 (See [https://builds.apache.org/job/ZooKeeper-trunk/1215/])
    

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff, ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042114#comment-13042114 ] 

Hadoop QA commented on ZOOKEEPER-1086:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481058/ZOOKEEPER-1086.diff
  against trunk revision 1125581.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/303//console

This message is automatically generated.

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1086) zookeeper test jar has non mavenised dependency.

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042266#comment-13042266 ] 

Patrick Hunt commented on ZOOKEEPER-1086:
-----------------------------------------

Perhaps we should just drop accessive? Questionable idea (mine) anyway, we could refactor the code instead. I ran into similar issues when creating maven support for building ZK itself. From what I can tell on the accessive site the author has not intention of publishing on a maven repo...

> zookeeper test jar has non mavenised dependency.
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-1086
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1086
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1086.diff
>
>
> The zookeeper test jar, (zookeeper-<version>-test.jar) depends on accessive.jar which is not available in maven. This is problematic for projects using the test jar (i.e. hedwig). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira