[jira] [Commented] (OFBIZ-6360) Form widget rendering broken for EmailServices.java

["Christian Carlow (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542421#comment-14542421 ] 

Christian Carlow commented on OFBIZ-6360:
-----------------------------------------

After the patch changes the form widget created for OFBIZ-6349 was rendered in the email message.  As mentioned in the previous post, the link locations don't point to valid URLs which may need to be handled by another issue.  Also CSS isn't applied to the email messages but the a resolution should probably be handled by a separate issue.

> Form widget rendering broken for EmailServices.java
> ---------------------------------------------------
>
>                 Key: OFBIZ-6360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6360
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Christian Carlow
>             Fix For: Trunk
>
>         Attachments: OFBIZ-6360.patch
>
>
> Currently only FTL files are rendered by EmailServices.java because formStringRenderer is null for HtmlScreenRenderer.java#renderScreenletSubWidget which is supposed to be extracted from the context parameter, previously from the request parameter, which never exists for the emailing service.  This issue was encountered when testing the sendQuoteReportMail service for the form widget that replaced the FTL for OFBIZ-6349.  
> EmailServices.java is still using the deprecated HtmlScreenRenderer and FoScreenRenderer which should both be replaced by MacroScreenRenderer.  This made me realize I left out the new header rendering functionality for patch OFBIZ-6354 for these two deprecated classes which probably need to be provided along with the existing patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)