You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/09 15:01:36 UTC
Review Request 59097: Fixed flakiness in agent registration
validation tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59097/
-----------------------------------------------------------
Review request for mesos, Jie Yu and James Peach.
Bugs: MESOS-7441
https://issues.apache.org/jira/browse/MESOS-7441
Repository: mesos
Description
-------
RegisterSlaveValidationTest.DropInvalidReregistration and
RegisterSlaveValidationTest.DropInvalidRegistration.
Diffs
-----
src/tests/master_validation_tests.cpp 3308803332bfae0d4b410eacd6d9a2a4a1265eff
Diff: https://reviews.apache.org/r/59097/diff/1/
Testing
-------
`make check`
`./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidReregistration" --gtest_repeat=2000 --gtest_break_on_failure .`
`./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidRegistration" --gtest_repeat=2000 --gtest_break_on_failure .`
Thanks,
Neil Conway
Re: Review Request 59097: Fixed flakiness in agent registration
validation tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59097/#review174356
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On May 9, 2017, 6 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59097/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 6 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-7441
> https://issues.apache.org/jira/browse/MESOS-7441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegisterSlaveValidationTest.DropInvalidReregistration and
> RegisterSlaveValidationTest.DropInvalidRegistration.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 3308803332bfae0d4b410eacd6d9a2a4a1265eff
>
>
> Diff: https://reviews.apache.org/r/59097/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> `./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidReregistration" --gtest_repeat=2000 --gtest_break_on_failure .`
> `./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidRegistration" --gtest_repeat=2000 --gtest_break_on_failure .`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59097: Fixed flakiness in agent registration
validation tests.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59097/
-----------------------------------------------------------
(Updated May 9, 2017, 6 p.m.)
Review request for mesos, Jie Yu and James Peach.
Changes
-------
Fixed additional flakiness in re-registration test, per jpeach report.
Bugs: MESOS-7441
https://issues.apache.org/jira/browse/MESOS-7441
Repository: mesos
Description
-------
RegisterSlaveValidationTest.DropInvalidReregistration and
RegisterSlaveValidationTest.DropInvalidRegistration.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 3308803332bfae0d4b410eacd6d9a2a4a1265eff
Diff: https://reviews.apache.org/r/59097/diff/2/
Changes: https://reviews.apache.org/r/59097/diff/1-2/
Testing
-------
`make check`
`./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidReregistration" --gtest_repeat=2000 --gtest_break_on_failure .`
`./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidRegistration" --gtest_repeat=2000 --gtest_break_on_failure .`
Thanks,
Neil Conway
Re: Review Request 59097: Fixed flakiness in agent registration
validation tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59097/#review174327
-----------------------------------------------------------
This improves the reliability of this test on my normal dev machine, but on my super slow vagrant VM this fails with the following error:
```
[ RUN ] RegisterSlaveValidationTest.DropInvalidReregistration
../../src/tests/master_validation_tests.cpp:3762: Failure
Failed to wait 15secs for reregisterSlaveMessage
*** Aborted at 1494344715 (unix time) try "date -d @1494344715" if you are using GNU date ***
PC: @ 0x55c82ca8fd10 testing::UnitTest::AddTestPartResult()
*** SIGSEGV (@0x0) received by PID 25238 (TID 0x7fadc2313860) from PID 0; stack trace: ***
@ 0x7fadbaecb7e0 (unknown)
@ 0x55c82ca8fd10 testing::UnitTest::AddTestPartResult()
@ 0x55c82ca84775 testing::internal::AssertHelper::operator=()
@ 0x55c82c07beab mesos::internal::tests::RegisterSlaveValidationTest_DropInvalidReregistration_Test::TestBody()
@ 0x55c82caad476 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x55c82caa86aa testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x55c82ca89aff testing::Test::Run()
@ 0x55c82ca8a28d testing::TestInfo::Run()
@ 0x55c82ca8a8b7 testing::TestCase::Run()
@ 0x55c82ca911f7 testing::internal::UnitTestImpl::RunAllTests()
@ 0x55c82caae105 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
@ 0x55c82caa91ca testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x55c82ca8ff2d testing::UnitTest::Run()
@ 0x55c82bdd917b RUN_ALL_TESTS()
@ 0x55c82bdd8c58 main
@ 0x7fadba3b4d1d (unknown)
@ 0x55c82b572179 (unknown)
```
- James Peach
On May 9, 2017, 3:01 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59097/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 3:01 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-7441
> https://issues.apache.org/jira/browse/MESOS-7441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> RegisterSlaveValidationTest.DropInvalidReregistration and
> RegisterSlaveValidationTest.DropInvalidRegistration.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 3308803332bfae0d4b410eacd6d9a2a4a1265eff
>
>
> Diff: https://reviews.apache.org/r/59097/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> `./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidReregistration" --gtest_repeat=2000 --gtest_break_on_failure .`
> `./src/mesos-tests --gtest_filter="RegisterSlaveValidationTest.DropInvalidRegistration" --gtest_repeat=2000 --gtest_break_on_failure .`
>
>
> Thanks,
>
> Neil Conway
>
>