You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/05/22 12:58:57 UTC
Review Request 67248: Fixed `pem_to_rsa` for older SSL versions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67248/
-----------------------------------------------------------
Review request for mesos, Clement Michaud and Till Toenshoff.
Repository: mesos
Description
-------
Fixed `pem_to_rsa` for older SSL versions.
Diffs
-----
3rdparty/libprocess/src/ssl/utilities.cpp 36a4cb1d9050285f53a7d75365f304747a7014cc
Diff: https://reviews.apache.org/r/67248/diff/1/
Testing
-------
`make check`
Code which failed to compile on e.g., centos6 now compiles there as well.
Thanks,
Benjamin Bannier
Re: Review Request 67248: Fixed `pem_to_rsa` for older SSL versions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67248/#review203583
-----------------------------------------------------------
PASS: Mesos patch 67248 was successfully built and tested.
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67248
- Mesos Reviewbot Windows
On May 22, 2018, 12:58 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67248/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 12:58 p.m.)
>
>
> Review request for mesos, Clement Michaud and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed `pem_to_rsa` for older SSL versions.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/utilities.cpp 36a4cb1d9050285f53a7d75365f304747a7014cc
>
>
> Diff: https://reviews.apache.org/r/67248/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Code which failed to compile on e.g., centos6 now compiles there as well.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67248: Fixed `pem_to_rsa` for older SSL versions.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67248/#review203566
-----------------------------------------------------------
Ship it!
Thanks a bunch Benjamin - guess I missed that in the CI runs, sorry for that.
- Till Toenshoff
On May 22, 2018, 12:58 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67248/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 12:58 p.m.)
>
>
> Review request for mesos, Clement Michaud and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed `pem_to_rsa` for older SSL versions.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/utilities.cpp 36a4cb1d9050285f53a7d75365f304747a7014cc
>
>
> Diff: https://reviews.apache.org/r/67248/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Code which failed to compile on e.g., centos6 now compiles there as well.
>
>
> Thanks,
>
> Benjamin Bannier
>
>