You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/01/02 07:13:11 UTC

[GitHub] weichao666 commented on a change in pull request #460: [JAV-566] report type/version when register to SC

weichao666 commented on a change in pull request #460: [JAV-566] report type/version when register to SC
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r159180171
 
 

 ##########
 File path: service-registry/src/main/resources/META-INF/maven/io/servicecomb/java-chassis/pom.properties
 ##########
 @@ -0,0 +1,3 @@
+groupId=io.servicecomb
 
 Review comment:
   in mavenVersionFor's source code?it need to read pom.properties,
   public static Version mavenVersionFor(ClassLoader classLoader, String groupId, String artifactId) {
       InputStream pomPoperties = classLoader.getResourceAsStream("META-INF/maven/" + 
           groupId.replaceAll("\\.", "/") + "/" + artifactId + "/pom.properties");

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services