You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/24 01:58:21 UTC
[GitHub] [tvm] areusch opened a new pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
areusch opened a new pull request #7512:
URL: https://github.com/apache/tvm/pull/7512
* These are filtered out in SetupOpExecs for normal debug runtime operation.
* Fixes use of debug runtime with µTVM.
@tmoreau89 @tqchen @jroesch @tkonolige
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7512:
URL: https://github.com/apache/tvm/pull/7512#issuecomment-786979090
Thanks @tkonolige @areusch the PR has been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 merged pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7512:
URL: https://github.com/apache/tvm/pull/7512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7512:
URL: https://github.com/apache/tvm/pull/7512#discussion_r583099525
##########
File path: src/runtime/graph/debug/graph_runtime_debug.cc
##########
@@ -110,6 +110,16 @@ class GraphRuntimeDebug : public GraphRuntime {
}
double RunOpRPC(int index, int number, int repeat, int min_repeat_ms) {
+ if (nodes_[index].op_type != "tvm_op") {
Review comment:
Could you just leave a comment for why we are doing this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #7512:
URL: https://github.com/apache/tvm/pull/7512#issuecomment-785258342
Is this for ops that are extern calls? Like calling into MKL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #7512:
URL: https://github.com/apache/tvm/pull/7512#discussion_r583102750
##########
File path: src/runtime/graph/debug/graph_runtime_debug.cc
##########
@@ -110,6 +110,16 @@ class GraphRuntimeDebug : public GraphRuntime {
}
double RunOpRPC(int index, int number, int repeat, int min_repeat_ms) {
+ if (nodes_[index].op_type != "tvm_op") {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7512:
URL: https://github.com/apache/tvm/pull/7512#issuecomment-786967506
@tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #7512: Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7512:
URL: https://github.com/apache/tvm/pull/7512#issuecomment-786136455
@tkonolige no, the GraphRuntime has two different paths to run operators: one for local operators where non-kernel ops could be done fairly inexpensively (I.e. layout transforms maybe? this isn't actually used) and one for RPC operators (where that is not easy). right now tvm_op == "null" (for graph nodes which are inputs) or "tvm_op" (for graph nodes which are operator function execs).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org