[GitHub] [incubator-superset] ktmud commented on a change in pull request #9495: Add explore control tabOverride at the section level

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #9495: Add explore control tabOverride at the section level
URL: https://github.com/apache/incubator-superset/pull/9495#discussion_r405898910
 
 

 ##########
 File path: superset-frontend/src/explore/components/ControlPanelsContainer.jsx
 ##########
 @@ -198,7 +198,10 @@ class ControlPanelsContainer extends React.Component {
     const querySectionsToRender = [];
     const displaySectionsToRender = [];
     allSectionsToRender.forEach(section => {
+      // if at least one control in the secion is not `renderTrigger`
+      // or asks to be displayed at the Data tab
       if (
+        section.tabOverride === 'data' ||
 
 Review comment:
   Yes, I think we should preprocess the configs at some point and avoid accounting for two types. I'll see what I can do later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org