You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by cd...@apache.org on 2006/08/09 12:52:50 UTC
svn commit: r430032 - in /forrest/trunk:
plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Author: cdupoirieux
Date: Wed Aug 9 03:52:50 2006
New Revision: 430032
URL: http://svn.apache.org/viewvc?rev=430032&view=rev
Log:
FOR-812 - Remove skniconf dependency
Add new properties to manage the project name, Url and the rss language.
Add a forrest.properties.xml to site-author to set the project name and URL...
Added:
forrest/trunk/site-author/forrest.properties.xml
Modified:
forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/default.plugin.properties.xml
forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources.xmap
forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/changes-to-rss.xsl
forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml
Modified: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/default.plugin.properties.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/default.plugin.properties.xml?rev=430032&r1=430031&r2=430032&view=diff
==============================================================================
--- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/default.plugin.properties.xml (original)
+++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/default.plugin.properties.xml Wed Aug 9 03:52:50 2006
@@ -16,6 +16,10 @@
limitations under the License.
-->
<properties>
+ <!-- Project identity -->
+ <property name="projectInfo.project.fullname" value="MyProject"/>
+ <property name="projectInfo.project.url" value="http://myproj.mygroup.org/"/>
+
<!-- A comma separated list defining the way actions are sorted in the changes file.
none = no sorting, will be listed in chronological order
type = group by the type attribute -->
@@ -30,4 +34,7 @@
<property name="projectInfo.changes.includeContributorList" value="true"/>
<property name="projectInfo.svn.ext" value=".svn.xml"/>
<property name="projectInfo.svn.path-prefix" value="src/documentation/content/svn-log/myProject-"/>
+
+ <!-- Indicate the rss flow language. Values are locale like : en-us, fr-fr, ... -->
+ <property name="projectInfo.rss.language" value="en-us"/>
</properties>
Modified: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources.xmap
URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources.xmap?rev=430032&r1=430031&r2=430032&view=diff
==============================================================================
--- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources.xmap (original)
+++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources.xmap Wed Aug 9 03:52:50 2006
@@ -30,20 +30,21 @@
<map:pipeline>
<map:match pattern="**changes.rss">
- <map:aggregate element="agg">
- <map:part src="cocoon://skinconf.xml"/>
- <map:part src="{lm:project.status}"/>
- </map:aggregate>
- <map:transform src="{lm:projectInfo.transform.changes.rss}"/>
+ <map:generate src="{lm:project.status}"/>
+ <map:transform src="{lm:projectInfo.transform.changes.rss}">
+ <map:parameter name="projectName" value="{project:projectInfo.project.fullname}"/>
+ <map:parameter name="projectUrl" value="{project:projectInfo.project.url}"/>
+ <map:parameter name="rssLanguage" value="{project:projectInfo.rss.language}"/>
+ </map:transform>
<map:serialize type="rss091" />
</map:match>
<map:match type="regexp" pattern="^(.*?)([^/]*)changes_(.*).rss$">
- <map:aggregate element="agg">
- <map:part src="cocoon://skinconf.xml"/>
- <map:part src="{lm:project.status}"/>
- </map:aggregate>
+ <map:generate src="{lm:project.status}"/>
<map:transform src="{lm:projectInfo.transform.changes.rss}">
+ <map:parameter name="projectName" value="{project:projectInfo.project.fullname}"/>
+ <map:parameter name="projectUrl" value="{project:projectInfo.project.url}"/>
+ <map:parameter name="rssLanguage" value="{project:projectInfo.rss.language}"/>
<map:parameter name="versionNumber" value="{3}"/>
</map:transform>
<map:serialize type="rss091" />
Modified: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/changes-to-rss.xsl
URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/changes-to-rss.xsl?rev=430032&r1=430031&r2=430032&view=diff
==============================================================================
--- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/changes-to-rss.xsl (original)
+++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/changes-to-rss.xsl Wed Aug 9 03:52:50 2006
@@ -18,9 +18,12 @@
<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
<xsl:param name="versionNumber"/>
+ <xsl:param name="projectName"/>
+ <xsl:param name="projectUrl"/>
+ <xsl:param name="rssLanguage"/>
<xsl:variable name="changes-url"
- select="concat(../skinconfig/project-url, 'changes.html')"/>
+ select="concat($projectUrl, 'changes.html')"/>
<xsl:template match="status">
@@ -28,13 +31,13 @@
<channel>
<xsl:choose>
<xsl:when test="$versionNumber = 'current'">
- <title><xsl:value-of select="../skinconfig/project-name"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</title>
+ <title><xsl:value-of select="$projectName"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</title>
</xsl:when>
<xsl:when test="$versionNumber">
- <title><xsl:value-of select="../skinconfig/project-name"/> (<xsl:value-of select="$versionNumber"/>) Changes</title>
+ <title><xsl:value-of select="$projectName"/> (<xsl:value-of select="$versionNumber"/>) Changes</title>
</xsl:when>
<xsl:otherwise>
- <title><xsl:value-of select="../skinconfig/project-name"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</title>
+ <title><xsl:value-of select="$projectName"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</title>
</xsl:otherwise>
</xsl:choose>
@@ -43,17 +46,17 @@
<xsl:choose>
<xsl:when test="$versionNumber = 'current'">
- <description><xsl:value-of select="../skinconfig/project-name"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</description>
+ <description><xsl:value-of select="$projectName"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</description>
</xsl:when>
<xsl:when test="$versionNumber">
- <description><xsl:value-of select="../skinconfig/project-name"/> (<xsl:value-of select="$versionNumber"/>) Changes</description>
+ <description><xsl:value-of select="$projectName"/> (<xsl:value-of select="$versionNumber"/>) Changes</description>
</xsl:when>
<xsl:otherwise>
- <description><xsl:value-of select="../skinconfig/project-name"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</description>
+ <description><xsl:value-of select="$projectName"/> (<xsl:value-of select="//release[1]/@version"/>) Changes</description>
</xsl:otherwise>
</xsl:choose>
- <language>en-us</language>
+ <language><xsl:value-of select="$rssLanguage"/></language>
<xsl:choose>
<xsl:when test="$versionNumber">
@@ -110,6 +113,7 @@
</item>
</xsl:template>
+ <!-- FIXME - not sure it is still needed since we do not use the skinconf.xml aggregation... -->
<xsl:template match="skinconfig"/>
<xsl:template match="notes"/>
<xsl:template match="todo"/>
Modified: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml?rev=430032&r1=430031&r2=430032&view=diff
==============================================================================
--- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml (original)
+++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml Wed Aug 9 03:52:50 2006
@@ -52,6 +52,9 @@
<p>This plugin provides various mechanisms for extracting and
displaying information about one or more projects.</p>
</notes>
+ <action type="fix" context="code" dev="CD" fixes-bug="FOR-812" importance="high">
+ Remove dependency of projectInfo on skinconf.xml.
+ </action>
<action type="update" context="code" dev="TS"> Adding svn support
specific properties to the default.plugin.properties.xml. Further
activated this new properties (projectInfo.svn.ext and
Added: forrest/trunk/site-author/forrest.properties.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/site-author/forrest.properties.xml?rev=430032&view=auto
==============================================================================
--- forrest/trunk/site-author/forrest.properties.xml (added)
+++ forrest/trunk/site-author/forrest.properties.xml Wed Aug 9 03:52:50 2006
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<properties>
+ <!-- Project identity -->
+ <property name="projectInfo.project.fullname" value="Forrest"/>
+ <property name="projectInfo.project.url" value="http://forrest.apache.org/"/>
+</properties>
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Ross Gardler <rg...@apache.org>.
Tim Williams wrote:
> On 8/9/06, Thorsten Scherler <th...@wyona.com> wrote:
>
>> El mié, 09-08-2006 a las 13:29 +0100, Ross Gardler escribió:
>> > cdupoirieux@apache.org wrote:
>> > > Author: cdupoirieux
>> > > Date: Wed Aug 9 03:52:50 2006
>> > > New Revision: 430032
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=430032&view=rev
>> > > Log:
>> > > FOR-812 - Remove skniconf dependency
>> > > Add new properties to manage the project name, Url and the rss
>> language.
>> > > Add a forrest.properties.xml to site-author to set the project
>> name and URL...
>> >
>> > -1
>> >
>> > We need to make a release of the plugin hat is compatible with 0.8
>> > before doing this. The new properties system is not officially included
>> > in the 0.8 release of Forrest.
>> >
>> > Having said that, recently the new config system has been seeing more
>> > people using it and it seems t work well, within certain limitations.
>> > Perhaps we should consider including the forrest.properties.xml in the
>> > 0.8 release. If this were to happen I could lift my -1 on this commit.
>> >
>>
>> I am not sure. The forrest.properties.xml is in 0.8-dev, right? If not
>> we could not use it at all. Meaning a 0.8 release will automatically
>> support forrest.properties.xml.
>>
>> I do not see any issue why the new properties system is not included
>> "officially". ...and what is the difference anyway? Like said the
>> 0.8-dev supports it.
>
>
> Not sure.
I have no objections to forrest.properties.xml being in 0.8 now that it
has recieved attention from other devs and therefore the implementation
(or at least the user view of it) should remain fairly stable.
Howeer, someone needs to document it.
>> Further why -1 here and not on the dispatcher that as well is using the
>> new system.
>
>
> Probably because the dispatcher is still in the whiteboard and thus
> comes with no implied stability assurances.
Precisely.
Ross
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/ plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/ site-author/
Posted by Tim Williams <wi...@gmail.com>.
On 8/9/06, Thorsten Scherler <th...@wyona.com> wrote:
> El mié, 09-08-2006 a las 13:29 +0100, Ross Gardler escribió:
> > cdupoirieux@apache.org wrote:
> > > Author: cdupoirieux
> > > Date: Wed Aug 9 03:52:50 2006
> > > New Revision: 430032
> > >
> > > URL: http://svn.apache.org/viewvc?rev=430032&view=rev
> > > Log:
> > > FOR-812 - Remove skniconf dependency
> > > Add new properties to manage the project name, Url and the rss language.
> > > Add a forrest.properties.xml to site-author to set the project name and URL...
> >
> > -1
> >
> > We need to make a release of the plugin hat is compatible with 0.8
> > before doing this. The new properties system is not officially included
> > in the 0.8 release of Forrest.
> >
> > Having said that, recently the new config system has been seeing more
> > people using it and it seems t work well, within certain limitations.
> > Perhaps we should consider including the forrest.properties.xml in the
> > 0.8 release. If this were to happen I could lift my -1 on this commit.
> >
>
> I am not sure. The forrest.properties.xml is in 0.8-dev, right? If not
> we could not use it at all. Meaning a 0.8 release will automatically
> support forrest.properties.xml.
>
> I do not see any issue why the new properties system is not included
> "officially". ...and what is the difference anyway? Like said the
> 0.8-dev supports it.
Not sure.
> Further why -1 here and not on the dispatcher that as well is using the
> new system.
Probably because the dispatcher is still in the whiteboard and thus
comes with no implied stability assurances.
--tim
Re: svn commit: r430032 - in /forrest/trunk:
plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Thorsten Scherler <th...@wyona.com>.
El mié, 09-08-2006 a las 13:29 +0100, Ross Gardler escribió:
> cdupoirieux@apache.org wrote:
> > Author: cdupoirieux
> > Date: Wed Aug 9 03:52:50 2006
> > New Revision: 430032
> >
> > URL: http://svn.apache.org/viewvc?rev=430032&view=rev
> > Log:
> > FOR-812 - Remove skniconf dependency
> > Add new properties to manage the project name, Url and the rss language.
> > Add a forrest.properties.xml to site-author to set the project name and URL...
>
> -1
>
> We need to make a release of the plugin hat is compatible with 0.8
> before doing this. The new properties system is not officially included
> in the 0.8 release of Forrest.
>
> Having said that, recently the new config system has been seeing more
> people using it and it seems t work well, within certain limitations.
> Perhaps we should consider including the forrest.properties.xml in the
> 0.8 release. If this were to happen I could lift my -1 on this commit.
>
I am not sure. The forrest.properties.xml is in 0.8-dev, right? If not
we could not use it at all. Meaning a 0.8 release will automatically
support forrest.properties.xml.
I do not see any issue why the new properties system is not included
"officially". ...and what is the difference anyway? Like said the
0.8-dev supports it.
Further why -1 here and not on the dispatcher that as well is using the
new system.
salu2
> If this were not to happen then this commit must increase the required
> Forrest version number within the plugin or in the plugin descriptor
> file (but only after a 0.8 compatible release was made).
>
> Ross
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
thorsten.scherler@wyona.com thorsten@apache.org
Re: svn commit: r430032 - in
/forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Thorsten Scherler <th...@apache.org>.
El mié, 09-08-2006 a las 15:30 +0200, Cyriaque Dupoirieux escribió:
> So, I revert my commit to be able to make a release of projectInfo ?
>
I understand Ross opinion now better, but I rather see some paragraph
about the new properties system in Forrest to make the whole bunch
official then this commit reverted.
I need to wrap up a proposal that will have effect on the
ForrestConfModule as whole and that IMO should be implemented before
releasing.
I consider the module as stable (only a small tweak is needed) and the
"new" component (the xml properties part) had as well a major review.
wdot?
salu2
> (And I will re-commit latter.)
>
> Ok ?
>
> Salutations,
> Cyriaque,
>
> And sorry for the noise :-( .
>
> le 09/08/2006 15:26 Ross Gardler a écrit :
> > Thorsten Scherler wrote:
> >> El mié, 09-08-2006 a las 14:40 +0200, Cyriaque Dupoirieux escribió:
> >>> le 09/08/2006 14:29 Ross Gardler a écrit :
> >>>
> >>>> cdupoirieux@apache.org wrote:
> >>>>
> >>>>> Author: cdupoirieux
> >>>>> Date: Wed Aug 9 03:52:50 2006
> >>>>> New Revision: 430032
> >>>>>
> >>>>> URL: http://svn.apache.org/viewvc?rev=430032&view=rev
> >>>>> Log:
> >>>>> FOR-812 - Remove skniconf dependency
> >>>>> Add new properties to manage the project name, Url and the rss
> >>>>> language.
> >>>>> Add a forrest.properties.xml to site-author to set the project
> >>>>> name and URL...
> >>>>
> >>>> -1
> >>>>
> >>>> We need to make a release of the plugin hat is compatible with 0.8
> >>>> before doing this. The new properties system is not officially
> >>>> included in the 0.8 release of Forrest.
> >>>>
> >>>> Having said that, recently the new config system has been seeing
> >>>> more people using it and it seems t work well, within certain
> >>>> limitations. Perhaps we should consider including the
> >>>> forrest.properties.xml in the 0.8 release. If this were to happen I
> >>>> could lift my -1 on this commit.
> >>>>
> >>>> If this were not to happen then this commit must increase the
> >>>> required Forrest version number within the plugin or in the plugin
> >>>> descriptor file (but only after a 0.8 compatible release was made).
> >>>
> >>> Just a moment, I have not created the forrest.properties.xml, it was
> >>> already there.
> >>>
> >>> Cyriaque,
> >>
> >>
> >> Yeah, that is right Cyriaque.
> >
> > As mentioned in an overlapping mail. The only use of the plugins that
> > I had noticed going through SVN were for experimental features.
> > However, see below...
> >
> >>
> >> Further there are other plugins using the property system (incl. the
> >> projectInfo before this commit).
> >
> > Only in whiteboard where stability of API is not required.
> >
> >> Ross can you explain why this commit is different to the one that added
> >> properties to default.forrest.properties.xml?
> >
> > Did previous changes move stable functionality over to using an
> > unstable properties implementation? If so then I missed the
> > significance of those changes.
> >
> > Furthermore, I missed the significance of the addition of new features
> > that used undocumented/unreleased and untested features of core.
> >
> > Of course, there is no problem with doing this as long as we have a
> > release of the plugin at the point at which it was only using stable
> > features.
> >
> > We now have a situation where a plugin that claims to be compatible
> > with 0.8 is using features that will not be a part of the 0.8 release.
> > See my original objects as to why this is a problem, together with my
> > further responses in other parts of this thread.
> >
> > Sorry I didn't pick up on this earlier, it only dawned on me when
> > Cyriaque did the right thing and asked if the community felt his
> > changes were OK.
> >
> > Ross
> >
> >
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 09/08/2006 15:45 Ross Gardler a écrit :
> Cyriaque Dupoirieux wrote:
>> So, I revert my commit to be able to make a release of projectInfo ?
>
> As Thorsten points out there are other commits that have used unstable
> stuff prior to yours. So lets decide what to do...
>
> The options I see are:
>
> 1) make the XML properties thing a part of the 0.8 roadmap (will o.8
> ever be released? Is the implementation of the new properties stable
> enough?)
I understand, that's a problem...
>
> 2) make a release of the plugin against 0.8 at a point before before
> Thorstens SVN log, then up the minimum required Forrest for this
> plugin to 0.9
It's a little complex : it seems that thorsten has started his work with
the r413182.
But you - Ross - have made some updates, as well as David, inbetween to
correct something with the Use Cases or with DOAP...
So, either we accept the first solution or we put comments in the code -
such as Ross has done in the forrest.properties.xml file...
Anyway, I think I am going to revert my commit tomorrow. (giving devs
time to react ;-) )
Cyriaque,
>
> Since I have no time for either I don't have a prefence, whichever is
> easier for those who need this stuff. I'm only tying to avoid the mess
> I made when I made changes to this plugin that were not compatible
> with 0.7 before I made a release for 0.7
>
>> (And I will re-commit latter.)
>
> Of course, your changes are great. Unfortunately they have highlighted
> a problem with our lack of process for managing plugin lifecycles.
>
> Ross
>
>
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Ross Gardler <rg...@apache.org>.
Cyriaque Dupoirieux wrote:
> So, I revert my commit to be able to make a release of projectInfo ?
As Thorsten points out there are other commits that have used unstable
stuff prior to yours. So lets decide what to do...
The options I see are:
1) make the XML properties thing a part of the 0.8 roadmap (will o.8
ever be released? Is the implementation of the new properties stable
enough?)
2) make a release of the plugin against 0.8 at a point before before
Thorstens SVN log, then up the minimum required Forrest for this plugin
to 0.9
Since I have no time for either I don't have a prefence, whichever is
easier for those who need this stuff. I'm only tying to avoid the mess I
made when I made changes to this plugin that were not compatible with
0.7 before I made a release for 0.7
> (And I will re-commit latter.)
Of course, your changes are great. Unfortunately they have highlighted a
problem with our lack of process for managing plugin lifecycles.
Ross
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
So, I revert my commit to be able to make a release of projectInfo ?
(And I will re-commit latter.)
Ok ?
Salutations,
Cyriaque,
And sorry for the noise :-( .
le 09/08/2006 15:26 Ross Gardler a écrit :
> Thorsten Scherler wrote:
>> El mié, 09-08-2006 a las 14:40 +0200, Cyriaque Dupoirieux escribió:
>>> le 09/08/2006 14:29 Ross Gardler a écrit :
>>>
>>>> cdupoirieux@apache.org wrote:
>>>>
>>>>> Author: cdupoirieux
>>>>> Date: Wed Aug 9 03:52:50 2006
>>>>> New Revision: 430032
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=430032&view=rev
>>>>> Log:
>>>>> FOR-812 - Remove skniconf dependency
>>>>> Add new properties to manage the project name, Url and the rss
>>>>> language.
>>>>> Add a forrest.properties.xml to site-author to set the project
>>>>> name and URL...
>>>>
>>>> -1
>>>>
>>>> We need to make a release of the plugin hat is compatible with 0.8
>>>> before doing this. The new properties system is not officially
>>>> included in the 0.8 release of Forrest.
>>>>
>>>> Having said that, recently the new config system has been seeing
>>>> more people using it and it seems t work well, within certain
>>>> limitations. Perhaps we should consider including the
>>>> forrest.properties.xml in the 0.8 release. If this were to happen I
>>>> could lift my -1 on this commit.
>>>>
>>>> If this were not to happen then this commit must increase the
>>>> required Forrest version number within the plugin or in the plugin
>>>> descriptor file (but only after a 0.8 compatible release was made).
>>>
>>> Just a moment, I have not created the forrest.properties.xml, it was
>>> already there.
>>>
>>> Cyriaque,
>>
>>
>> Yeah, that is right Cyriaque.
>
> As mentioned in an overlapping mail. The only use of the plugins that
> I had noticed going through SVN were for experimental features.
> However, see below...
>
>>
>> Further there are other plugins using the property system (incl. the
>> projectInfo before this commit).
>
> Only in whiteboard where stability of API is not required.
>
>> Ross can you explain why this commit is different to the one that added
>> properties to default.forrest.properties.xml?
>
> Did previous changes move stable functionality over to using an
> unstable properties implementation? If so then I missed the
> significance of those changes.
>
> Furthermore, I missed the significance of the addition of new features
> that used undocumented/unreleased and untested features of core.
>
> Of course, there is no problem with doing this as long as we have a
> release of the plugin at the point at which it was only using stable
> features.
>
> We now have a situation where a plugin that claims to be compatible
> with 0.8 is using features that will not be a part of the 0.8 release.
> See my original objects as to why this is a problem, together with my
> further responses in other parts of this thread.
>
> Sorry I didn't pick up on this earlier, it only dawned on me when
> Cyriaque did the right thing and asked if the community felt his
> changes were OK.
>
> Ross
>
>
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> El mié, 09-08-2006 a las 14:40 +0200, Cyriaque Dupoirieux escribió:
>
>>le 09/08/2006 14:29 Ross Gardler a écrit :
>>
>>>cdupoirieux@apache.org wrote:
>>>
>>>>Author: cdupoirieux
>>>>Date: Wed Aug 9 03:52:50 2006
>>>>New Revision: 430032
>>>>
>>>>URL: http://svn.apache.org/viewvc?rev=430032&view=rev
>>>>Log:
>>>>FOR-812 - Remove skniconf dependency
>>>>Add new properties to manage the project name, Url and the rss language.
>>>>Add a forrest.properties.xml to site-author to set the project name
>>>>and URL...
>>>
>>>-1
>>>
>>>We need to make a release of the plugin hat is compatible with 0.8
>>>before doing this. The new properties system is not officially
>>>included in the 0.8 release of Forrest.
>>>
>>>Having said that, recently the new config system has been seeing more
>>>people using it and it seems t work well, within certain limitations.
>>>Perhaps we should consider including the forrest.properties.xml in the
>>>0.8 release. If this were to happen I could lift my -1 on this commit.
>>>
>>>If this were not to happen then this commit must increase the required
>>>Forrest version number within the plugin or in the plugin descriptor
>>>file (but only after a 0.8 compatible release was made).
>>
>>Just a moment, I have not created the forrest.properties.xml, it was
>>already there.
>>
>>Cyriaque,
>
>
> Yeah, that is right Cyriaque.
As mentioned in an overlapping mail. The only use of the plugins that I
had noticed going through SVN were for experimental features. However,
see below...
>
> Further there are other plugins using the property system (incl. the
> projectInfo before this commit).
Only in whiteboard where stability of API is not required.
> Ross can you explain why this commit is different to the one that added
> properties to default.forrest.properties.xml?
Did previous changes move stable functionality over to using an unstable
properties implementation? If so then I missed the significance of those
changes.
Furthermore, I missed the significance of the addition of new features
that used undocumented/unreleased and untested features of core.
Of course, there is no problem with doing this as long as we have a
release of the plugin at the point at which it was only using stable
features.
We now have a situation where a plugin that claims to be compatible with
0.8 is using features that will not be a part of the 0.8 release. See my
original objects as to why this is a problem, together with my further
responses in other parts of this thread.
Sorry I didn't pick up on this earlier, it only dawned on me when
Cyriaque did the right thing and asked if the community felt his changes
were OK.
Ross
Re: svn commit: r430032 - in /forrest/trunk:
plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Thorsten Scherler <th...@wyona.com>.
El mié, 09-08-2006 a las 14:40 +0200, Cyriaque Dupoirieux escribió:
> le 09/08/2006 14:29 Ross Gardler a écrit :
> > cdupoirieux@apache.org wrote:
> >> Author: cdupoirieux
> >> Date: Wed Aug 9 03:52:50 2006
> >> New Revision: 430032
> >>
> >> URL: http://svn.apache.org/viewvc?rev=430032&view=rev
> >> Log:
> >> FOR-812 - Remove skniconf dependency
> >> Add new properties to manage the project name, Url and the rss language.
> >> Add a forrest.properties.xml to site-author to set the project name
> >> and URL...
> >
> > -1
> >
> > We need to make a release of the plugin hat is compatible with 0.8
> > before doing this. The new properties system is not officially
> > included in the 0.8 release of Forrest.
> >
> > Having said that, recently the new config system has been seeing more
> > people using it and it seems t work well, within certain limitations.
> > Perhaps we should consider including the forrest.properties.xml in the
> > 0.8 release. If this were to happen I could lift my -1 on this commit.
> >
> > If this were not to happen then this commit must increase the required
> > Forrest version number within the plugin or in the plugin descriptor
> > file (but only after a 0.8 compatible release was made).
> Just a moment, I have not created the forrest.properties.xml, it was
> already there.
>
> Cyriaque,
Yeah, that is right Cyriaque.
Further there are other plugins using the property system (incl. the
projectInfo before this commit).
Ross can you explain why this commit is different to the one that added
properties to default.forrest.properties.xml?
salu2
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
thorsten.scherler@wyona.com thorsten@apache.org
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Ross Gardler <rg...@apache.org>.
Cyriaque Dupoirieux wrote:
> le 09/08/2006 14:29 Ross Gardler a écrit :
>
>> cdupoirieux@apache.org wrote:
>>
>>> Author: cdupoirieux
>>> Date: Wed Aug 9 03:52:50 2006
>>> New Revision: 430032
>>>
>>> URL: http://svn.apache.org/viewvc?rev=430032&view=rev
>>> Log:
>>> FOR-812 - Remove skniconf dependency
>>> Add new properties to manage the project name, Url and the rss language.
>>> Add a forrest.properties.xml to site-author to set the project name
>>> and URL...
>>
>>
>> -1
>>
>> We need to make a release of the plugin hat is compatible with 0.8
>> before doing this. The new properties system is not officially
>> included in the 0.8 release of Forrest.
>>
>> Having said that, recently the new config system has been seeing more
>> people using it and it seems t work well, within certain limitations.
>> Perhaps we should consider including the forrest.properties.xml in the
>> 0.8 release. If this were to happen I could lift my -1 on this commit.
>>
>> If this were not to happen then this commit must increase the required
>> Forrest version number within the plugin or in the plugin descriptor
>> file (but only after a 0.8 compatible release was made).
>
> Just a moment, I have not created the forrest.properties.xml, it was
> already there.
Yes, but it is used in a section of the projectInfo plugin that is
clearly marked on the index page as "experimental". This commit uses it
for something that has been in use since around Forrest 0.2
Ross
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 09/08/2006 14:29 Ross Gardler a écrit :
> cdupoirieux@apache.org wrote:
>> Author: cdupoirieux
>> Date: Wed Aug 9 03:52:50 2006
>> New Revision: 430032
>>
>> URL: http://svn.apache.org/viewvc?rev=430032&view=rev
>> Log:
>> FOR-812 - Remove skniconf dependency
>> Add new properties to manage the project name, Url and the rss language.
>> Add a forrest.properties.xml to site-author to set the project name
>> and URL...
>
> -1
>
> We need to make a release of the plugin hat is compatible with 0.8
> before doing this. The new properties system is not officially
> included in the 0.8 release of Forrest.
>
> Having said that, recently the new config system has been seeing more
> people using it and it seems t work well, within certain limitations.
> Perhaps we should consider including the forrest.properties.xml in the
> 0.8 release. If this were to happen I could lift my -1 on this commit.
>
> If this were not to happen then this commit must increase the required
> Forrest version number within the plugin or in the plugin descriptor
> file (but only after a 0.8 compatible release was made).
Just a moment, I have not created the forrest.properties.xml, it was
already there.
Cyriaque,
>
> Ross
>
>
Re: svn commit: r430032 - in /forrest/trunk: plugins/org.apache.forrest.plugin.input.projectInfo/
plugins/org.apache.forrest.plugin.input.projectInfo/resources/stylesheets/
site-author/
Posted by Ross Gardler <rg...@apache.org>.
cdupoirieux@apache.org wrote:
> Author: cdupoirieux
> Date: Wed Aug 9 03:52:50 2006
> New Revision: 430032
>
> URL: http://svn.apache.org/viewvc?rev=430032&view=rev
> Log:
> FOR-812 - Remove skniconf dependency
> Add new properties to manage the project name, Url and the rss language.
> Add a forrest.properties.xml to site-author to set the project name and URL...
-1
We need to make a release of the plugin hat is compatible with 0.8
before doing this. The new properties system is not officially included
in the 0.8 release of Forrest.
Having said that, recently the new config system has been seeing more
people using it and it seems t work well, within certain limitations.
Perhaps we should consider including the forrest.properties.xml in the
0.8 release. If this were to happen I could lift my -1 on this commit.
If this were not to happen then this commit must increase the required
Forrest version number within the plugin or in the plugin descriptor
file (but only after a 0.8 compatible release was made).
Ross