You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/01/18 16:01:26 UTC
[arrow] branch master updated: ARROW-1966: [C++] Accommodate
JAVA_HOME on Linux that includes the jre/ directory,
or is the full path to directory with libjvm
This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new bc9f9e5 ARROW-1966: [C++] Accommodate JAVA_HOME on Linux that includes the jre/ directory, or is the full path to directory with libjvm
bc9f9e5 is described below
commit bc9f9e532ea2a16810d5ce14e1dfc3272628cb95
Author: Wes McKinney <we...@twosigma.com>
AuthorDate: Thu Jan 18 11:01:23 2018 -0500
ARROW-1966: [C++] Accommodate JAVA_HOME on Linux that includes the jre/ directory, or is the full path to directory with libjvm
Some users ran into a rough edge where they had a non-standard JRE directory (possibly related to some recent changes by Oracle in their JDK installer)
Author: Wes McKinney <we...@twosigma.com>
Closes #1487 from wesm/ARROW-1966 and squashes the following commits:
7e14923d [Wes McKinney] Add note to API documentation about JAVA_HOME
f77b31e6 [Wes McKinney] Accommodate a JAVA_HOME containing the jre/ directory, or an absolute path to directory containing libjvm
---
cpp/apidoc/HDFS.md | 4 ++++
cpp/src/arrow/io/hdfs-internal.cc | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/cpp/apidoc/HDFS.md b/cpp/apidoc/HDFS.md
index d54ad27..d3671fb 100644
--- a/cpp/apidoc/HDFS.md
+++ b/cpp/apidoc/HDFS.md
@@ -50,6 +50,10 @@ export CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath --glob`
* `ARROW_LIBHDFS_DIR` (optional): explicit location of `libhdfs.so` if it is
installed somewhere other than `$HADOOP_HOME/lib/native`.
+To accommodate distribution-specific nuances, the `JAVA_HOME` variable may be
+set to the root path for the Java SDK, the JRE path itself, or to the directory
+containing the `libjvm` library.
+
### Mac Specifics
The installed location of Java on OS X can vary, however the following snippet
diff --git a/cpp/src/arrow/io/hdfs-internal.cc b/cpp/src/arrow/io/hdfs-internal.cc
index 9cd1c50..545b2d1 100644
--- a/cpp/src/arrow/io/hdfs-internal.cc
+++ b/cpp/src/arrow/io/hdfs-internal.cc
@@ -147,7 +147,7 @@ static std::vector<fs::path> get_potential_libjvm_paths() {
file_name = "jvm.dll";
#elif __APPLE__
search_prefixes = {""};
- search_suffixes = {"", "/jre/lib/server"};
+ search_suffixes = {"", "/jre/lib/server", "/lib/server"};
file_name = "libjvm.dylib";
// SFrame uses /usr/libexec/java_home to find JAVA_HOME; for now we are
@@ -175,7 +175,7 @@ static std::vector<fs::path> get_potential_libjvm_paths() {
"/usr/lib/jvm/default", // alt centos
"/usr/java/latest", // alt centos
};
- search_suffixes = {"/jre/lib/amd64/server"};
+ search_suffixes = {"", "/jre/lib/amd64/server", "/lib/amd64/server"};
file_name = "libjvm.so";
#endif
// From direct environment variable
--
To stop receiving notification emails like this one, please contact
['"commits@arrow.apache.org" <co...@arrow.apache.org>'].