You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/10 20:38:25 UTC

[GitHub] [incubator-superset] eugene-belarus opened a new issue #10832: Shortcuts Ctrl + r, Ctrl + s, Ctrl + t of Explore & SQL Lab

eugene-belarus opened a new issue #10832:
URL: https://github.com/apache/incubator-superset/issues/10832


   There's no **Ctrl + r** hot key & **Ctrl + s** invokes default Chrome save page in Explore.
   **Ctrl + t** invokes default Chrome new tab in SQL Lab.
   
   _There's one Chromium issue about Ctrl + t_
   > Issue 33056: Ctrl keys: Ctrl-N, Ctrl-T and Ctrl-W no longer available to client side JavaScript in Chrome4
   
   > In Chrome 4 it works similary to Firefox, except some keyboard combination:
   > 
   > - Ctrl + N
   > - Ctrl + Shift + N
   > - Ctrl + T
   > - Ctrl + Shift + T
   > - Ctrl + W
   > - Ctrl + Shift + W
   > 
   > These combinations cannot get captured by Javascript.
   
   ### Expected results
   
   All shortcuts work.
   
   ### Actual results
   
   Explore hot key **Ctrl + r** does not exist.
   Explore hot key **Ctrl + s** invokes default Chrome save page.
   SQL Lab hot key **Ctrl + t** invokes default Chrome new tab.
   
   #### Screenshots
   
   Explore hot keys
   ![Screenshot 1](https://user-images.githubusercontent.com/71097330/92797918-2eeded00-f3bb-11ea-8481-9d7917ea972c.png)
   
   SQL LAb hot keys
   ![Screenshot 2](https://user-images.githubusercontent.com/71097330/92797948-36ad9180-f3bb-11ea-9e2d-0df1ed38d34f.png)
   
   #### How to reproduce the bug 1
   
   1. Go to a chart
   2. Press **Ctrl + r** & **Ctrl + s**
   3. Hot key **Ctrl + r** does not exist
   4. Hot key **Ctrl + s** invokes default Chrome save page
   
   #### How to reproduce the bug 2
   
   1. Go to SQL Lab
   2. Press **Ctrl + t**
   3. Hot key **Ctrl + t** invokes default Chrome new tab
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] stale[bot] commented on issue #10832: Shortcuts Ctrl + r, Ctrl + s, Ctrl + t of Explore & SQL Lab

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10832:
URL: https://github.com/apache/incubator-superset/issues/10832#issuecomment-734495230


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10832: Shortcuts Ctrl + r, Ctrl + s, Ctrl + t of Explore & SQL Lab

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10832:
URL: https://github.com/apache/incubator-superset/issues/10832#issuecomment-690713447


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.71. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] willbarrett commented on issue #10832: Shortcuts Ctrl + r, Ctrl + s, Ctrl + t of Explore & SQL Lab

Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #10832:
URL: https://github.com/apache/incubator-superset/issues/10832#issuecomment-691553392


   Thanks for the bug report! We'll look into it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org