You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/12/12 10:00:05 UTC
Review Request 41299: Allow DockerContainerizer log to console.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Timothy Chen.
Bugs: MESOS-4141
https://issues.apache.org/jira/browse/MESOS-4141
Repository: mesos
Description
-------
Allow DockerContainerizer log to console.
Diffs
-----
src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
Diff: https://reviews.apache.org/r/41299/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review110111
-----------------------------------------------------------
Ship it!
Ship It!
src/slave/containerizer/docker.cpp (line 835)
<https://reviews.apache.org/r/41299/#comment169893>
Default is None already.
src/slave/containerizer/docker.cpp (line 838)
<https://reviews.apache.org/r/41299/#comment169892>
Space in between here please.
- Timothy Chen
On Dec. 12, 2015, 9 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 9 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
> src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
> src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
> src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
> src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by haosdent huang <ha...@gmail.com>.
> On Dec. 14, 2015, 7:28 p.m., Joseph Wu wrote:
> > FYI, I'm making conflicting changes as part of work on a "logging module". I published an incomplete patch so you can see the conflicts:
> > https://reviews.apache.org/r/41294/
>
> haosdent huang wrote:
> Thank you very much. Should I discard my patch first? Basically I just want to unify Containerizer interface, then put it forward become a module.
>
> Joseph Wu wrote:
> You probably don't need to discard. I just wanted to let you know about a future rebase conflict :)
Got it. I would rebase after your patch submitted.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review110290
-----------------------------------------------------------
On Dec. 13, 2015, 5:35 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 5:35 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
> src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
> src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
> src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
> src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 14, 2015, 11:28 a.m., Joseph Wu wrote:
> > FYI, I'm making conflicting changes as part of work on a "logging module". I published an incomplete patch so you can see the conflicts:
> > https://reviews.apache.org/r/41294/
>
> haosdent huang wrote:
> Thank you very much. Should I discard my patch first? Basically I just want to unify Containerizer interface, then put it forward become a module.
You probably don't need to discard. I just wanted to let you know about a future rebase conflict :)
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review110290
-----------------------------------------------------------
On Dec. 12, 2015, 9:35 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 9:35 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
> src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
> src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
> src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
> src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by haosdent huang <ha...@gmail.com>.
> On Dec. 14, 2015, 7:28 p.m., Joseph Wu wrote:
> > FYI, I'm making conflicting changes as part of work on a "logging module". I published an incomplete patch so you can see the conflicts:
> > https://reviews.apache.org/r/41294/
Thank you very much. Should I discard my patch first? Basically I just want to unify Containerizer interface, then put it forward become a module.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review110290
-----------------------------------------------------------
On Dec. 13, 2015, 5:35 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 5:35 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
> src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
> src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
> src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
> src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review110290
-----------------------------------------------------------
FYI, I'm making conflicting changes as part of work on a "logging module". I published an incomplete patch so you can see the conflicts:
https://reviews.apache.org/r/41294/
src/slave/containerizer/docker.cpp (lines 835 - 854)
<https://reviews.apache.org/r/41299/#comment170106>
There's also some output in [src/docker/executor.cpp](https://github.com/apache/mesos/blob/dc6cde747eec94ba35aae5f5587d80338c000068/src/docker/executor.cpp#L141-L150).
- Joseph Wu
On Dec. 12, 2015, 9:35 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 9:35 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
> src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
> src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
> src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
> src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review115983
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41299]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 23, 2016, 8:58 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 8:58 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 5e7e55e2dd4e451bb754a6a888e9683760d95873
> src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3
> src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0
> src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397
> src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
> src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2
> src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
> src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 24, 2016, 8:21 a.m., Guangya Liu wrote:
> > I saw that all of the unit test are using `false` for `local`, can you please write some test scenarios in `Testing Done` area?
Sure, I test this local before. Add a new unit test would be better.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review116013
-----------------------------------------------------------
On Jan. 23, 2016, 8:58 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 8:58 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 5e7e55e2dd4e451bb754a6a888e9683760d95873
> src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3
> src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0
> src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397
> src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
> src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2
> src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
> src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review116013
-----------------------------------------------------------
I saw that all of the unit test are using `false` for `local`, can you please write some test scenarios in `Testing Done` area?
- Guangya Liu
On 一月 23, 2016, 8:58 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated 一月 23, 2016, 8:58 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 5e7e55e2dd4e451bb754a6a888e9683760d95873
> src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3
> src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0
> src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397
> src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
> src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2
> src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
> src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/
-----------------------------------------------------------
(Updated Jan. 23, 2016, 8:58 a.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
Fix @kaysoky comments.
Bugs: MESOS-4141
https://issues.apache.org/jira/browse/MESOS-4141
Repository: mesos
Description
-------
Allow DockerContainerizer log to console.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp 5e7e55e2dd4e451bb754a6a888e9683760d95873
src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3
src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0
src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397
src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
Diff: https://reviews.apache.org/r/41299/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review110156
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41299]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 13, 2015, 5:35 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 5:35 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow DockerContainerizer log to console.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
> src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
> src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
> src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
> src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
> src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
> src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
>
> Diff: https://reviews.apache.org/r/41299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41299: Allow DockerContainerizer log to console.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/
-----------------------------------------------------------
(Updated Dec. 13, 2015, 5:35 a.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
Address comments
Bugs: MESOS-4141
https://issues.apache.org/jira/browse/MESOS-4141
Repository: mesos
Description
-------
Allow DockerContainerizer log to console.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d
src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e
src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c
src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187
src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8
src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97
Diff: https://reviews.apache.org/r/41299/diff/
Testing
-------
Thanks,
haosdent huang