[jira] [Comment Edited] (HTRACE-331) create git tags for 4.0 and 4.0.1 releases

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056543#comment-15056543 ] 

Colin Patrick McCabe edited comment on HTRACE-331 at 12/14/15 7:32 PM:
-----------------------------------------------------------------------

bq. The tag for the '4.0 release' should be 4.0.0? Not 4.0? Or, maybe the issue is that we shouldn't have done a 4.0 release but a 4.0.0 release instead (If so, then, yeah, we stuck... but could tag it with 4.0.0... and that'd match tagging the 4.0.1 release with 4.0.1...)

I'm imagining a conversation with a new community member now.  The guy runs "git checkout 4.0"
My response: "Oh no, don't check out 4.0, that's actually the name of a branch which currently contains htrace 4.0.1, not htrace 4.0.  Instead you need to check out 4.0.0, even though the release was named 4.0."  Facepalm.

I think we should just follow the convention that:
* release branches have "branch" in the name.  So the branch for 4.1 will be "branch-4.1"
* release tags have "release" in the name.  So the tag for htrace 4.1 will be 4.1-release

That makes it absolutely clear whether you're checking out a branch or a release tag.  What do you think?  If you guys agree, I'll go ahead and create 4.0-release and 4.0.1-release tags.


was (Author: cmccabe):
bq. The tag for the '4.0 release' should be 4.0.0? Not 4.0? Or, maybe the issue is that we shouldn't have done a 4.0 release but a 4.0.0 release instead (If so, then, yeah, we stuck... but could tag it with 4.0.0... and that'd match tagging the 4.0.1 release with 4.0.1...)

I'm imaging a conversation with a new community member now.  The guy runs "git checkout 4.0"
My response: "Oh no, don't check out 4.0, that's actually the name of a branch which currently contains htrace 4.0.1, not htrace 4.0.  Instead you need to check out 4.0.0, even though the release was named 4.0."  Facepalm.

I think we should just follow the convention that:
* release branches have "branch" in the name.  So the branch for 4.1 will be "branch-4.1"
* release tags have "release" in the name.  So the tag for htrace 4.1 will be 4.1-release

That makes it absolutely clear whether you're checking out a branch or a release tag.  What do you think?  If you guys agree, I'll go ahead and create 4.0-release and 4.0.1-release tags.

> create git tags for 4.0 and 4.0.1 releases
> ------------------------------------------
>
>                 Key: HTRACE-331
>                 URL: https://issues.apache.org/jira/browse/HTRACE-331
>             Project: HTrace
>          Issue Type: Task
>          Components: docs
>    Affects Versions: 4.0, 4.0.1
>            Reporter: Sean Busbey
>            Priority: Critical
>
> Versions 4.0 and 4.0.1 are released, but there aren't corresponding git tags. There's only 4.0.1 RC tags.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)