You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/05 22:26:20 UTC
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10001: style(mypy): Spit-and-polish pass
john-bodley commented on a change in pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#discussion_r436191232
##########
File path: superset/utils/cache.py
##########
@@ -27,8 +27,9 @@ def view_cache_key(*args: Any, **kwargs: Any) -> str: # pylint: disable=unused-
def memoized_func(
- key: Callable = view_cache_key, attribute_in_key: Optional[str] = None
-) -> Callable:
+ key: Callable[..., str] = view_cache_key, # pylint: disable=bad-whitespace
Review comment:
Note I'm unsure why `pylint` is barfing here. Per SIP-46 there's tentative plans to fix all the `pylint` issues (including bumping the version) and I sense for now we should just accept the `pylint` "regressions".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org