You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/19 05:57:33 UTC

[GitHub] [kafka] chia7712 opened a new pull request #9620: MINOR: Get rid of generic from FetchResponse

chia7712 opened a new pull request #9620:
URL: https://github.com/apache/kafka/pull/9620


   Except for LazyDownConversionRecords, we don't use the generic. We should handle the specify case directly instead of making generic in whole project.
   
   In short, this patch is a kind of cleanup.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 closed pull request #9620: MINOR: Get rid of generic from FetchResponse

Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #9620:
URL: https://github.com/apache/kafka/pull/9620


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9620: MINOR: Get rid of generic from FetchResponse

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9620:
URL: https://github.com/apache/kafka/pull/9620#issuecomment-741859826


   It's a bit hard to know when the Lazy version can be used though, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9620: MINOR: Get rid of generic from FetchResponse

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9620:
URL: https://github.com/apache/kafka/pull/9620#issuecomment-778412955


   superseded by #9758


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9620: MINOR: Get rid of generic from FetchResponse

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9620:
URL: https://github.com/apache/kafka/pull/9620#issuecomment-741868042


   > It's a bit hard to know when the Lazy version can be used though, right?
   
   You are right :(
   
   Will go back when I have a better idea.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org