You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/09/06 17:36:51 UTC
[GitHub] [accumulo] keith-turner opened a new issue #1351: Add test to
GarbageCollectorIT for continue point or remove continue point
keith-turner opened a new issue #1351: Add test to GarbageCollectorIT for continue point or remove continue point
URL: https://github.com/apache/accumulo/issues/1351
Accumulo garbage collection will read a batch of deletes into memory and process them. When reading the next batch it uses the last path it saw as a continue point. Need to ensure the continue point code covers all data.
Alternatively, instead of testing the continue point code it could be removed by refactoring the GC code as follows so that continue is not needed. The code below keeps the iterator for the entire cycle instead of calling continue.
```java
Iterator<String> candidates = getContext().getAmple().getGcCandidates(level);
while(candidates.hasNext()){
List<String> candidatesBatch = readCandidatesThatFitInMemory(candidates);
collectBatch(candidatesBatch);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services