You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/06/25 01:57:52 UTC

[GitHub] [orc] wgtmac opened a new pull request, #1552: ORC-1455: [C++] Fix build with unused macro in CpuInfoUtil.cc

wgtmac opened a new pull request, #1552:
URL: https://github.com/apache/orc/pull/1552

   ### What changes were proposed in this pull request?
   Move UNUSED macro under the definition of CPUINFO_ARCH_X86 in order to avoid unused macro error.
   
   ### Why are the changes needed?
   Without this patch, the C++ build fails on MacOS and other non-x86 machines.
   
   ### How was this patch tested?
   It builds successfully and passes all tests on my laptop.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1552: ORC-1455: [C++] Fix build with unused macro in CpuInfoUtil.cc

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1552:
URL: https://github.com/apache/orc/pull/1552#issuecomment-1606152741

   Thank you, @wgtmac and @guiyanakuang .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #1552: ORC-1455: [C++] Fix build with unused macro in CpuInfoUtil.cc

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun merged PR #1552:
URL: https://github.com/apache/orc/pull/1552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org