[jira] Commented: (HADOOP-2855) [HOD] HOD fails to allocate a cluster if the tarball specified is a relative path

["Hemanth Yamijala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581872#action_12581872 ] 

Hemanth Yamijala commented on HADOOP-2855:
------------------------------------------

Couple of comments:

- Need unit test cases for validation and normalization of uri and directories.
- We are validating the hadoop tar ball URI on the client. Since the current expectation is that the tarball exists only on the compute nodes, this may result in some regression - even though it is an unlikely scenario. Even if we keep this, the error message on validation failure is a bit confusing. It says invalid uri, but as far as the user is concerned it just seems like a file path to him.
- For every datatype in types.py, there are 4 functions. The display_uri function is one of the 4 that's missing. Is this required ?
- Do we need to do expanduser in types.py: __normalizePath ?
- The code for verify_uri and norm_uri is trying to normalize a path even if the uri begins with file://. If we specify the URI in this format, I don't think the path can be relative, right ? So, I think we should only be checking for empty string, and not 'file' for the value of component[0].


> [HOD] HOD fails to allocate a cluster if the tarball specified is a relative path
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-2855
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2855
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>    Affects Versions: 0.16.0
>            Reporter: Hemanth Yamijala
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-2855
>
>
> Run hod -t my-tar.tar.gz -o "allocate hod-cluster 3". Ringmaster fails to come up. The log shows the exception as an invalid URL for the tarball file. Basically HOD should translate the relative path to an absolute path and send it to the ringmaster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.