You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/02/06 20:13:08 UTC
[jira] Created: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Factor TableOperation and subclasses into separate files from HMaster
---------------------------------------------------------------------
Key: HBASE-417
URL: https://issues.apache.org/jira/browse/HBASE-417
Project: Hadoop HBase
Issue Type: Sub-task
Reporter: Bryan Duxbury
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567928#action_12567928 ]
Bryan Duxbury commented on HBASE-417:
-------------------------------------
Stack, looks like you committed a documentation change, not my patch.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417-v5.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Attachment: 417-v5.patch
There were some problems with v4.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417-v5.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HBASE-417) Factor TableOperation and
subclasses into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-417 started by Bryan Duxbury.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned HBASE-417:
-----------------------------------
Assignee: Bryan Duxbury
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568523#action_12568523 ]
Hudson commented on HBASE-417:
------------------------------
Integrated in Hadoop-trunk #399 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/399/])
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417-v5.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Attachment: 417.patch
Here's a pass at it.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Description:
In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Attachment: 417-v3.patch
Here's some improvements.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Attachment: 417-v2.patch
Here's a version that's merged with trunk. Tests pass locally.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Status: Patch Available (was: In Progress)
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568070#action_12568070 ]
Hudson commented on HBASE-417:
------------------------------
Integrated in Hadoop-trunk #398 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/398/])
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417-v5.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567731#action_12567731 ]
stack commented on HBASE-417:
-----------------------------
Copyright notices should be 2008, not 2007.
In DeleteColumns, not a blocker, but seems odd passing HMaster inner classes out to these TableOperation classes; should MetaTable be moved out of HMaster too?
These could be made final?
{code}
+ private HColumnDescriptor descriptor;
+ private Text columnName;
{code}
... etc. for all other TableOperation classes.
Otherwise, patch is a big improvement.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567978#action_12567978 ]
stack commented on HBASE-417:
-----------------------------
Sorry about that. Done.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417-v5.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Priority: Minor (was: Major)
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Priority: Minor
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HBASE-417:
--------------------------------
Fix Version/s: 0.2.0
Affects Version/s: 0.2.0
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417-v5.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-417:
------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed v5 with some clean up (removed imports mainly). Thanks for the patch Bryan.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417-v5.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-417) Factor TableOperation and subclasses
into separate files from HMaster
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HBASE-417:
--------------------------------
Attachment: 417-v4.patch
This one factors out BaseScanner, RootScanner, and MetaScanner as well.
> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
> Key: HBASE-417
> URL: https://issues.apache.org/jira/browse/HBASE-417
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 417-v2.patch, 417-v3.patch, 417-v4.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least.
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.