You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/08/09 20:59:04 UTC

Review Request: SQOOP-567: Support connection validation in JDBC repository

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6497/
-----------------------------------------------------------

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.


Description
-------

Pretty straightforward implementation of the request.


This addresses bug SQOOP-567.
    https://issues.apache.org/jira/browse/SQOOP-567


Diffs
-----

  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1371266 
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 1371266 
  /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1371266 

Diff: https://reviews.apache.org/r/6497/diff/


Testing
-------

Only manual test performed.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-567: Support connection validation in JDBC repository

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6497/#review10093
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Aug. 9, 2012, 6:59 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6497/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 6:59 p.m.)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Description
> -------
> 
> Pretty straightforward implementation of the request.
> 
> 
> This addresses bug SQOOP-567.
>     https://issues.apache.org/jira/browse/SQOOP-567
> 
> 
> Diffs
> -----
> 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1371266 
>   /branches/sqoop2/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 1371266 
>   /branches/sqoop2/repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 1371266 
> 
> Diff: https://reviews.apache.org/r/6497/diff/
> 
> 
> Testing
> -------
> 
> Only manual test performed.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>