You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@isis.apache.org by "Dan Haywood (Commented) (JIRA)" <ji...@apache.org> on 2011/11/04 00:27:32 UTC

[jira] [Commented] (ISIS-127) Some Facets (eg ActionChoicesFacetViaMethod) have an AdapterMap (ie AdapterManager) injected into them. I think this is a mistake...

    [ https://issues.apache.org/jira/browse/ISIS-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143604#comment-13143604 ] 

Dan Haywood commented on ISIS-127:
----------------------------------

On further investigation, this isn't a mistake or error.  We actually inject an AdapterManager impl that delegates to the current IsisSession.  Therefore am rejecting this ticket.
                
> Some Facets (eg ActionChoicesFacetViaMethod) have an AdapterMap (ie AdapterManager) injected into them.  I think this is a mistake...
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-127
>                 URL: https://issues.apache.org/jira/browse/ISIS-127
>             Project: Isis
>          Issue Type: Bug
>          Components: Core: ProgModel
>    Affects Versions: 0.1.2-incubating
>            Reporter: Dan Haywood
>
> ... because each time a PersistenceSession is created, a new AdapterManagerDefault is instantiated.
> Instead, we should inject an AdapterManagerProvider into the facet that obtains the currently-scoped AdapterManager as required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira