You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/10 09:59:29 UTC
[GitHub] [airflow] methane commented on issue #4558: [AIRFLOW-3731]
Constrain mysqlclient to <1.4
methane commented on issue #4558: [AIRFLOW-3731] Constrain mysqlclient to <1.4
URL: https://github.com/apache/airflow/pull/4558#issuecomment-563957769
I removed `__exit__` from mysqlclient because it was not many people expects, including Airflow.
https://github.com/apache/airflow/blob/7bebe8ddbc69ed5a1b316d31a2aa542f6bc60432/tests/operators/test_operators.py#L354-L363
https://github.com/apache/airflow/blob/7bebe8ddbc69ed5a1b316d31a2aa542f6bc60432/tests/operators/test_operators.py#L370-L371
The Airflow expect `__exit__` close the connection. But it didn't. It did commit or rollback.
So there are connection leaks in your code.
Since this interface is different from many people expects, I am changing it:
1. deprecate it.
2. remove it. (now)
3. add `__exit__` which closes the connection. (in near future).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services