[GitHub] [superset] betodealmeida commented on a diff in pull request #21794: fix(trino): Ensure get_table_names only returns physical tables

[GitBox <gi...@apache.org>]

betodealmeida commented on code in PR #21794:
URL: https://github.com/apache/superset/pull/21794#discussion_r994142486


##########
superset/db_engine_specs/presto.py:
##########
@@ -392,28 +392,49 @@ def update_impersonation_config(
 
     @classmethod
     def get_table_names(
-        cls, database: Database, inspector: Inspector, schema: Optional[str]
+        cls,
+        database: Database,
+        inspector: Inspector,
+        schema: Optional[str],
     ) -> List[str]:
-        tables = super().get_table_names(database, inspector, schema)
-        if not is_feature_enabled("PRESTO_SPLIT_VIEWS_FROM_TABLES"):

Review Comment:
   When I added the feature at Lyft it would take 90 seconds to read all the views, so I thought it would be better to put it behind a feature flag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org