[jira] [Commented] (MESOS-1893) Authenticator Module: Location and Naming

["Till Toenshoff (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196937#comment-14196937 ] 

Till Toenshoff commented on MESOS-1893:
---------------------------------------

commit b51f55500b809b452123c011012227d821e02c04
Author: Till Toenshoff <to...@me.com>
Date:   Mon Nov 3 14:39:42 2014 -0800

    Reorganized authentication implementation locations.

    For paving the way into further authentication mechanism
    implementations, the existing is reorganized.

    Move src/sasl to src/authentication/cram_md5.
    Rename src/tests/sasl_tests.cpp to src/tests/cram_md5_authentication_tests.cpp.
    Adapt depending include paths.
    Rename specific test implementations from SASL to CRAMMD5Authentication.
    Rename sasl namespace to cram_md5 throughout all uses.
    Add missing license blob to auxprop.cpp.

    Review: https://reviews.apache.org/r/27122

> Authenticator Module: Location and Naming
> -----------------------------------------
>
>                 Key: MESOS-1893
>                 URL: https://issues.apache.org/jira/browse/MESOS-1893
>             Project: Mesos
>          Issue Type: Improvement
>          Components: modules
>            Reporter: Till Toenshoff
>            Assignee: Till Toenshoff
>            Priority: Blocker
>
> h4. Motivation
> Render a well structured and mesos-alike naming and folder tree. This shall be similar to what we know from the awesome! containerizer structure.
> h4. Folder Structure
> For the flat-file Authenticator Module but also for authentication as a whole, I would like to propose the following structural changes:
> - move {{authenticator.hpp}} out of {{sasl/}}
> - create a new {{authentication/}}
> -- put the module interface here and name it {{authenticator.hpp}}
> - create a new {{authentication/cram_md5}}
> -- put the default/module implementation here and name it {{authenticator.hpp}} 
> -- mind that I am proposing {{cram_md5}} instead of {{sasl}} due to the fact that cyrus-sasl2 offers many more mechanisms but our current default (CRAM-MD5) and further dividing the tree into sasl and non-sasl based authentications may be too verbosive/bloated.
> h4. Module Naming
> Following the module naming scheme, I would like to propose {{org_apache_mesos_authenticator_crammd5}} to be used for our first/default Authenticator. Mind that in this case I did not reflect the folder tree into this reverse domain alike description as I find it more intuitive to have the module before the kind - objections?
> h4. Library Naming
> Given that we will also add an authenticatee to this library, a proper name would be 
> {{libauthentication_crammd5.so/dylib}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)