You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/05/27 01:40:38 UTC
[GitHub] carbondata pull request #961: [CARBONDATA-1098] change PageStatistics to use...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/961
[CARBONDATA-1098] change PageStatistics to use exact type
Currently page statistics uses Object internally, which requires boxing/unboxing when processing it.
This PR changes it to use exact type as schema defines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata stats
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/961.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #961
----
commit aefbedacfec309c3d3345dcacd285c1aa2890523
Author: jackylk <ja...@huawei.com>
Date: 2017-05-27T01:26:03Z
change PageStatistics to use exact type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #961: [CARBONDATA-1098] change PageStatistics to use exact ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/961
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #961: [CARBONDATA-1098] change PageStatistics to use exact ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/961
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/335/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #961: [CARBONDATA-1098] change PageStatistics to use exact ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/961
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2454/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #961: [CARBONDATA-1098] change PageStatistics to use...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #961: [CARBONDATA-1098] change PageStatistics to use...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/961#discussion_r121898445
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java ---
@@ -195,15 +192,36 @@ private int getDecimalCount(double value) {
}
public Object getMin() {
- return min;
+ switch (dataType) {
+ case BYTE:
+ case SHORT:
+ case INT:
+ case LONG:
+ return minLong;
+ case FLOAT:
+ case DOUBLE:
+ return minDouble;
+ case DECIMAL:
+ return minDecimal;
+ default:
+ return null;
+ }
}
public Object getMax() {
- return max;
- }
-
- public Object nonExistValue() {
- return nonExistValue;
+ switch (dataType) {
+ case SHORT:
--- End diff --
please use the same datatype set in all switch case statements of this class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #961: [CARBONDATA-1098] change PageStatistics to use exact ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/961
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/349/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #961: [CARBONDATA-1098] change PageStatistics to use exact ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/961
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2465/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---