You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/04 18:47:54 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request #3476: NO-JIRA: GHA workflow improvements
gemmellr opened a new pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476
- Builds the examples using the release profile on JDK8, as the Travis job does.
- Build the examples on JDK11+ using the -Pexamples,noRun profiles for equivalent build (release profile requires JDK8), which the Travis build doesnt do.
- Adds a workflow_dispatch trigger, allowing manual start of a new test runs (on any branch), without overwriting all the previous run logs like using the 'rerun all jobs' button within a particular run result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3476: NO-JIRA: GHA workflow improvements
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476#issuecomment-791338394
> I also actually thought it always built at least a good chunk of the
overall javadoc, since it often looks to be one of the things really
slowing the Artemis build down overall. I've certainly wanted to suggest
disabling it in the default build before as it's so slow. Maybe it doesn't
build it all though, while at release it does?
That seems to be the case, the artemis-website module spends a chunk of time (~1.5min in CI) triggering building javadoc for select modules: artemis-core-client, artemis-jms-client, artemis-server, artemis-jms-server, artemis-journal, artemis-selector. Presumably the release does every module or builds them slightly differently, such that you encountered an error in an area that wasnt seen previously during the above artemis-website bits.
The artemis-website module is always building those javadoc bits currently, even though it isnt normally building the actual docs for the site, which it only does in the release profile. I dont see any we wouldn't just move the javadoc builds into the release profile too (or add another related profile to trigger it). Does anyone typically look at that output before release, given its available in the IDEs already if you want it during dev, say while you are editing it? After that you can then set up a either nightly build that verifies it (GHA has cron from scheduling), or something triggered by each commit. I tend to do the nightly, given it doesnt change much and is slow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3476: NO-JIRA: GHA workflow improvements
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476#discussion_r587798821
##########
File path: .github/workflows/build.yml
##########
@@ -32,8 +32,15 @@ jobs:
- name: Build Main
run: |
mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -Pjmh install
- - name: Build Examples
+
+ - name: Build Examples (JDK8 / -Prelease)
+ if: matrix.java == '8'
Review comment:
I wanted to prevent people breaking javadocs again.. or at least be aware when that happens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3476: NO-JIRA: GHA workflow improvements
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3476: NO-JIRA: GHA workflow improvements
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476#issuecomment-790951764
Essentially yep... If you mean for the main build you would probably add a
new separate named step for Javadoc, before the examples steps, i.e copy
the block rather than just add that line to it.
Also, though the release profile needs JDK8, could you just do
javadoc:javadoc on all JDKs without the profile? We certainly had that
building on 8-14 when we first introduced ability to build with >8, I fixed
lots of javadoc errors at least (warnings still there, but don't fail the
build).
Either way, I'd expect the javadoc to build on them all eventually, and as
the newer ones are typically stricter it's probably those that most need
checked. So even if it were needed for now, an 'if JDK8' restriction on
that should probably be removed in time.
I also actually thought it always built at least a good chunk of the
overall javadoc, since it often looks to be one of the things really
slowing the Artemis build down overall. I've certainly wanted to suggest
disabling it in the default build before as it's so slow. Maybe it doesn't
build it all though, while at release it does?
On Thu, 4 Mar 2021, 20:21 clebertsuconic, <no...@github.com> wrote:
> *@clebertsuconic* commented on this pull request.
> ------------------------------
>
> In .github/workflows/build.yml
> <https://github.com/apache/activemq-artemis/pull/3476#discussion_r587798568>
> :
>
> > @@ -32,8 +32,15 @@ jobs:
> - name: Build Main
> run: |
> mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -Pjmh install
> - - name: Build Examples
> +
> + - name: Build Examples (JDK8 / -Prelease)
> + if: matrix.java == '8'
>
> @gemmellr <https://github.com/gemmellr> before last release, I had to fix
> javadoc, however currently javadoc only builds on JDK 1.8
>
> I tried to do an if jdk=8 at the time but I did not know how to do it?
>
> Since you figured it out now, can we add after this line?
>
> mvn -Prelease javadoc:javadoc
>
> WDYT?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/activemq-artemis/pull/3476#pullrequestreview-604524832>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABG6ZBYVZSFN3JMPZMQCKR3TB7TTVANCNFSM4YTZI4WQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3476: NO-JIRA: GHA workflow improvements
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476#issuecomment-791308570
Annoying that email replies dont actually show up in the 'comment thread' that caused them hehe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3476: NO-JIRA: GHA workflow improvements
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476#discussion_r587798568
##########
File path: .github/workflows/build.yml
##########
@@ -32,8 +32,15 @@ jobs:
- name: Build Main
run: |
mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -Pjmh install
- - name: Build Examples
+
+ - name: Build Examples (JDK8 / -Prelease)
+ if: matrix.java == '8'
Review comment:
@gemmellr before last release, I had to fix javadoc, however currently javadoc only builds on JDK 1.8
I tried to do an if jdk=8 at the time but I did not know how to do it?
Since you figured it out now, can we add after this line?
```mvn -Prelease javadoc:javadoc```
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org