[jira] [Commented] (FLINK-7519) Enrich ClientRestException with HttpResponseStatus

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141510#comment-16141510 ] 

ASF GitHub Bot commented on FLINK-7519:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4588

    [FLINK-7519] Add HttpResponseStatus to RestClientException

    ## What is the purpose of the change
    
    
    Enrich the RestClientException with the HttpResponseStatus in case of failures. This makes the exception handling on the client side easier.
    
    This PR is based on #4569.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink enrichedClientRestException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4588.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4588
    
----
commit 508c04b8db633290faea0b8d9a1539203892682e
Author: zentol <ch...@apache.org>
Date:   2017-08-16T13:17:45Z

    [FLINK-7040] [rest] Add basics for REST communication
    
    Add better error message for get requests with a body
    
    Consistent error message for 404
    
    Rework resolve URL generation
    
    Rework handler registration
    
    Support concurrent requests
    
    Rework client response receival
    
    Rework handler response (remove HandlerResponse class)
    
    tests: move client/server shutdown into finally block
    
    Close connection in ClientHandler
    
    Proper shutdown of netty stack
    
    simplify RestClientEndpoint lambda chain
    
    Provide handlers with access to MessageParameters

commit 70fed8ab8d7937764e3d7135afd6d32a3c01829f
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-25T09:46:04Z

    [FLINK-7040] [rest] Introduce executor, shutdown timeouts and future completion in failure case to RestServerEndpoint
    
    This commit also moves the target address and target port specification to the
    RestClient#sendRequest call instead of passing the connection information to the
    constructor of the RestClient.

commit 2212132ae9b8cdd3a8434c7ad60f94b4c83155f3
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-25T10:15:38Z

    [FLINK-7519] Add HttpResponseStatus to RestClientException
    
    Enrich the RestClientException with the HttpResponseStatus in case of failures. This
    makes the exception handling on the client side easier.

----


> Enrich ClientRestException with HttpResponseStatus
> --------------------------------------------------
>
>                 Key: FLINK-7519
>                 URL: https://issues.apache.org/jira/browse/FLINK-7519
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> The {{RestClient}} should include the {{HttpResponseStatus}} in its thrown {{RestClientException}}. This allows better exception handling on the client side (similar to the {{RestHandlerException}}).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)