You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2018/06/13 21:13:37 UTC
Review Request 67584: Update to Mesos 1.5
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Renan DelValle.
Repository: aurora
Description
-------
This is an upgrade to Mesos 1.5.0. While 1.5.1 is already released, there are no Debian
packages and jars available yet.
The mesos.interface Python package has a requirement on a newer protobuf version.
I applied the same update to Java for consistency.
* Mesos 1.5 changelog: https://mesos.apache.org/blog/mesos-1-5-0-released/
* Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/#upgrading-from-1-4-x-to-1-5-x
* Protobuf changelog: https://github.com/google/protobuf/blob/3.5.x/CHANGES.txt
Diffs
-----
3rdparty/python/BUILD f06c3f346033ca8351d01a17836c6f3cb2a5fc08
3rdparty/python/requirements.txt 72be82f5ff47d7989a604984dcd0d348e0cc76f8
RELEASE-NOTES.md 0ef75d601ef7c170c81f574aad12de2c8afce7b0
Vagrantfile 5b59dba6d305bcbcb6285e8cdfee337f4a584f99
build-support/packer/aurora.json da279174bb7a48b51a67ee825dfbdca409648f79
build-support/packer/build.sh 7c36f74ee8d498df9c282a8891e720f60cfd576a
build.gradle 57355dceaec41cd97256d954337ecb3ca0c50ba1
Diff: https://reviews.apache.org/r/67584/diff/1/
Testing
-------
Finished successfully:
* `./build-support/jenkins/build.sh`
* `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box)
Running as we speak:
* `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box)
Thanks,
Stephan Erb
Re: Review Request 67584: Update to Mesos 1.5
Posted by se choi <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/#review204845
-----------------------------------------------------------
Ship it!
Ship It!
- se choi
On 6 14, 2018, 7:08 오전, Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67584/
> -----------------------------------------------------------
>
> (Updated 6 14, 2018, 7:08 오전)
>
>
> Review request for Aurora, David McLaughlin and Renan DelValle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an upgrade to Mesos 1.5.0. While 1.5.1 is already released, there are no Debian
> packages and jars available yet.
>
> The mesos.interface Python package has a requirement on a newer protobuf version.
> I applied the same update to Java for consistency.
>
> * Mesos 1.5 changelog: https://mesos.apache.org/blog/mesos-1-5-0-released/
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/#upgrading-from-1-4-x-to-1-5-x
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.5.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD f06c3f346033ca8351d01a17836c6f3cb2a5fc08
> 3rdparty/python/requirements.txt 72be82f5ff47d7989a604984dcd0d348e0cc76f8
> RELEASE-NOTES.md 0ef75d601ef7c170c81f574aad12de2c8afce7b0
> Vagrantfile 5b59dba6d305bcbcb6285e8cdfee337f4a584f99
> build-support/packer/aurora.json da279174bb7a48b51a67ee825dfbdca409648f79
> build-support/packer/build.sh 7c36f74ee8d498df9c282a8891e720f60cfd576a
> build.gradle 57355dceaec41cd97256d954337ecb3ca0c50ba1
>
>
> Diff: https://reviews.apache.org/r/67584/diff/1/
>
>
> Testing
> -------
>
> Finished successfully:
>
> * `./build-support/jenkins/build.sh`
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box)
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67584: Update to Mesos 1.5
Posted by Renan DelValle <re...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/#review204738
-----------------------------------------------------------
Ship it!
Ship It!
- Renan DelValle
On June 13, 2018, 3:08 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67584/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 3:08 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Renan DelValle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an upgrade to Mesos 1.5.0. While 1.5.1 is already released, there are no Debian
> packages and jars available yet.
>
> The mesos.interface Python package has a requirement on a newer protobuf version.
> I applied the same update to Java for consistency.
>
> * Mesos 1.5 changelog: https://mesos.apache.org/blog/mesos-1-5-0-released/
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/#upgrading-from-1-4-x-to-1-5-x
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.5.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD f06c3f346033ca8351d01a17836c6f3cb2a5fc08
> 3rdparty/python/requirements.txt 72be82f5ff47d7989a604984dcd0d348e0cc76f8
> RELEASE-NOTES.md 0ef75d601ef7c170c81f574aad12de2c8afce7b0
> Vagrantfile 5b59dba6d305bcbcb6285e8cdfee337f4a584f99
> build-support/packer/aurora.json da279174bb7a48b51a67ee825dfbdca409648f79
> build-support/packer/build.sh 7c36f74ee8d498df9c282a8891e720f60cfd576a
> build.gradle 57355dceaec41cd97256d954337ecb3ca0c50ba1
>
>
> Diff: https://reviews.apache.org/r/67584/diff/1/
>
>
> Testing
> -------
>
> Finished successfully:
>
> * `./build-support/jenkins/build.sh`
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box)
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67584: Update to Mesos 1.5
Posted by Stephan Erb <se...@apache.org>.
> On Juni 15, 2018, 8 nachm., David McLaughlin wrote:
> > Vagrantfile
> > Line 20 (original), 20 (patched)
> > <https://reviews.apache.org/r/67584/diff/1/?file=2040319#file2040319line20>
> >
> > Why this downgrade?
That is just the minimal version and it works fine with 2.0.2 as well.
For super unfortunate reason I am stuck with 2.0.2 on a workstation of mine :-/
> On Juni 15, 2018, 8 nachm., David McLaughlin wrote:
> > Vagrantfile
> > Line 26 (original), 26 (patched)
> > <https://reviews.apache.org/r/67584/diff/1/?file=2040319#file2040319line26>
> >
> > Why this upgrade? :)
This is a new build of our vagrant box with Mesos 1.5.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/#review204855
-----------------------------------------------------------
On Juni 14, 2018, 12:08 vorm., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67584/
> -----------------------------------------------------------
>
> (Updated Juni 14, 2018, 12:08 vorm.)
>
>
> Review request for Aurora, David McLaughlin and Renan DelValle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an upgrade to Mesos 1.5.0. While 1.5.1 is already released, there are no Debian
> packages and jars available yet.
>
> The mesos.interface Python package has a requirement on a newer protobuf version.
> I applied the same update to Java for consistency.
>
> * Mesos 1.5 changelog: https://mesos.apache.org/blog/mesos-1-5-0-released/
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/#upgrading-from-1-4-x-to-1-5-x
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.5.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD f06c3f346033ca8351d01a17836c6f3cb2a5fc08
> 3rdparty/python/requirements.txt 72be82f5ff47d7989a604984dcd0d348e0cc76f8
> RELEASE-NOTES.md 0ef75d601ef7c170c81f574aad12de2c8afce7b0
> Vagrantfile 5b59dba6d305bcbcb6285e8cdfee337f4a584f99
> build-support/packer/aurora.json da279174bb7a48b51a67ee825dfbdca409648f79
> build-support/packer/build.sh 7c36f74ee8d498df9c282a8891e720f60cfd576a
> build.gradle 57355dceaec41cd97256d954337ecb3ca0c50ba1
>
>
> Diff: https://reviews.apache.org/r/67584/diff/1/
>
>
> Testing
> -------
>
> Finished successfully:
>
> * `./build-support/jenkins/build.sh`
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box)
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67584: Update to Mesos 1.5
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/#review204855
-----------------------------------------------------------
Ship it!
Vagrantfile
Line 20 (original), 20 (patched)
<https://reviews.apache.org/r/67584/#comment287608>
Why this downgrade?
Vagrantfile
Line 26 (original), 26 (patched)
<https://reviews.apache.org/r/67584/#comment287609>
Why this upgrade? :)
- David McLaughlin
On June 13, 2018, 10:08 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67584/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 10:08 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Renan DelValle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an upgrade to Mesos 1.5.0. While 1.5.1 is already released, there are no Debian
> packages and jars available yet.
>
> The mesos.interface Python package has a requirement on a newer protobuf version.
> I applied the same update to Java for consistency.
>
> * Mesos 1.5 changelog: https://mesos.apache.org/blog/mesos-1-5-0-released/
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/#upgrading-from-1-4-x-to-1-5-x
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.5.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD f06c3f346033ca8351d01a17836c6f3cb2a5fc08
> 3rdparty/python/requirements.txt 72be82f5ff47d7989a604984dcd0d348e0cc76f8
> RELEASE-NOTES.md 0ef75d601ef7c170c81f574aad12de2c8afce7b0
> Vagrantfile 5b59dba6d305bcbcb6285e8cdfee337f4a584f99
> build-support/packer/aurora.json da279174bb7a48b51a67ee825dfbdca409648f79
> build-support/packer/build.sh 7c36f74ee8d498df9c282a8891e720f60cfd576a
> build.gradle 57355dceaec41cd97256d954337ecb3ca0c50ba1
>
>
> Diff: https://reviews.apache.org/r/67584/diff/1/
>
>
> Testing
> -------
>
> Finished successfully:
>
> * `./build-support/jenkins/build.sh`
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box)
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box)
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 67584: Update to Mesos 1.5
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/
-----------------------------------------------------------
(Updated June 14, 2018, 12:08 a.m.)
Review request for Aurora, David McLaughlin and Renan DelValle.
Repository: aurora
Description
-------
This is an upgrade to Mesos 1.5.0. While 1.5.1 is already released, there are no Debian
packages and jars available yet.
The mesos.interface Python package has a requirement on a newer protobuf version.
I applied the same update to Java for consistency.
* Mesos 1.5 changelog: https://mesos.apache.org/blog/mesos-1-5-0-released/
* Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/#upgrading-from-1-4-x-to-1-5-x
* Protobuf changelog: https://github.com/google/protobuf/blob/3.5.x/CHANGES.txt
Diffs
-----
3rdparty/python/BUILD f06c3f346033ca8351d01a17836c6f3cb2a5fc08
3rdparty/python/requirements.txt 72be82f5ff47d7989a604984dcd0d348e0cc76f8
RELEASE-NOTES.md 0ef75d601ef7c170c81f574aad12de2c8afce7b0
Vagrantfile 5b59dba6d305bcbcb6285e8cdfee337f4a584f99
build-support/packer/aurora.json da279174bb7a48b51a67ee825dfbdca409648f79
build-support/packer/build.sh 7c36f74ee8d498df9c282a8891e720f60cfd576a
build.gradle 57355dceaec41cd97256d954337ecb3ca0c50ba1
Diff: https://reviews.apache.org/r/67584/diff/1/
Testing (updated)
-------
Finished successfully:
* `./build-support/jenkins/build.sh`
* `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box)
* `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box)
Thanks,
Stephan Erb
Re: Review Request 67584: Update to Mesos 1.5
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/#review204735
-----------------------------------------------------------
Ship it!
Master (748babb) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 13, 2018, 9:13 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67584/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 9:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Renan DelValle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an upgrade to Mesos 1.5.0. While 1.5.1 is already released, there are no Debian
> packages and jars available yet.
>
> The mesos.interface Python package has a requirement on a newer protobuf version.
> I applied the same update to Java for consistency.
>
> * Mesos 1.5 changelog: https://mesos.apache.org/blog/mesos-1-5-0-released/
> * Mesos update instructions: https://mesos.apache.org/documentation/latest/upgrades/#upgrading-from-1-4-x-to-1-5-x
> * Protobuf changelog: https://github.com/google/protobuf/blob/3.5.x/CHANGES.txt
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD f06c3f346033ca8351d01a17836c6f3cb2a5fc08
> 3rdparty/python/requirements.txt 72be82f5ff47d7989a604984dcd0d348e0cc76f8
> RELEASE-NOTES.md 0ef75d601ef7c170c81f574aad12de2c8afce7b0
> Vagrantfile 5b59dba6d305bcbcb6285e8cdfee337f4a584f99
> build-support/packer/aurora.json da279174bb7a48b51a67ee825dfbdca409648f79
> build-support/packer/build.sh 7c36f74ee8d498df9c282a8891e720f60cfd576a
> build.gradle 57355dceaec41cd97256d954337ecb3ca0c50ba1
>
>
> Diff: https://reviews.apache.org/r/67584/diff/1/
>
>
> Testing
> -------
>
> Finished successfully:
>
> * `./build-support/jenkins/build.sh`
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0 (new vagrant box)
>
> Running as we speak:
>
> * `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0 (old vagrant box)
>
>
> Thanks,
>
> Stephan Erb
>
>