You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by iskl <gi...@git.apache.org> on 2017/01/16 03:59:45 UTC
[GitHub] incubator-rocketmq pull request #43: [ROCKETMQ-59] Change Charset usages in ...
GitHub user iskl opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/43
[ROCKETMQ-59] Change Charset usages in RocketMQSerializable to Rocket\u2026
The PR is to resolve [issue-59](https://issues.apache.org/jira/browse/ROCKETMQ-59)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iskl/incubator-rocketmq ROCKETMQ-59
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 5358cc2de6bb32a0aa4afed18c342f618f000b75
Author: Kailai Shao <sh...@kailai.me>
Date: 2017-01-16T03:57:19Z
[ROCKETMQ-59] Change Charset usages in RocketMQSerializable to RocketMQSerializable#CHARSET_UTF8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #43: [ROCKETMQ-59] Change Charset usages in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #43: [ROCKETMQ-59] Change Charset usages in RocketM...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/43
Minor changes, appears OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #43: [ROCKETMQ-59] Change Charset usages in RocketM...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/43
alright, thanks @iskl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #43: [ROCKETMQ-59] Change Charset usages in RocketM...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/43
@iskl It could be better if we narrow down `CHARSET_UTF8 ` access modifier to `private` and without `static`, for both `RocketMQSerializable` and `RemotingSerializable`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #43: [ROCKETMQ-59] Change Charset usages in RocketM...
Posted by iskl <gi...@git.apache.org>.
Github user iskl commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/43
@zhouxinyu That's really a better solution! I've change the access modifiers to `private` for borh.
Since the CHARSET is used in `static` methods, it could not be modified to non-static.
Please help to review~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---