You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/29 03:07:27 UTC

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2934: [Bug][seatunnel-format-json] Fix jackson package conflict with spark

Hisoka-X commented on code in PR #2934:
URL: https://github.com/apache/incubator-seatunnel/pull/2934#discussion_r983021828


##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/JsonToRowConverters.java:
##########
@@ -83,33 +86,103 @@ private JsonToRowConverter createNotNullConverter(SeaTunnelDataType<?> type) {
             case ROW:
                 return createRowConverter((SeaTunnelRowType) type);
             case NULL:
-                return jsonNode -> null;
+                return new JsonToRowConverter() {

Review Comment:
   Add comment about why not use lambda.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org