You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/11 14:30:32 UTC

[GitHub] [arrow-rs] alamb opened a new pull request, #1686: Add gRPC service reflection support to arrow flight

alamb opened a new pull request, #1686:
URL: https://github.com/apache/arrow-rs/pull/1686

   # Which issue does this PR close?
   
   TBF
   Closes #.
   
   # Rationale for this change
   We like to use the gRPC service reflection, via  `grpcurl --plaintext localhost:8082 list`, to list gRPC services in IOx
   
   We have a flight based service that does not appear in the service list (see https://github.com/influxdata/influxdb_iox/issues/4543)
   
   I think this is because the arrow-flight library doesn't create the appropriate descriptors, but I am not sure
   
   # What changes are included in this PR?
   
   Try to generate the appropriate service descriptor
   
   # Are there any user-facing changes?
   Can now use reflection (if using https://crates.io/crates/tonic-reflection)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb closed pull request #1686: Add gRPC service reflection support to arrow flight

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #1686: Add gRPC service reflection support to arrow flight
URL: https://github.com/apache/arrow-rs/pull/1686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #1686: Add gRPC service reflection support to arrow flight

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1686:
URL: https://github.com/apache/arrow-rs/pull/1686#issuecomment-1125880132

   I think we would likely need to make the generated descriptor set available as a constant within the produced binary, so that it can be passed to the reflection https://docs.rs/tonic-reflection/0.4.0/tonic_reflection/server/struct.Builder.html.
   
   Effectively all gRPC reflection is, is a service that returns the compiled descriptor sets, which in turn are just a parsed version of the proto files, represented as protobuf - https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/descriptor.proto


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1686: Add gRPC service reflection support to arrow flight

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1686:
URL: https://github.com/apache/arrow-rs/pull/1686#issuecomment-1127613247

   Closing this PR as it isn't working -- have filed https://github.com/apache/arrow-rs/issues/1706 to track the real issue and maybe someone else will want to work on it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org