[GitHub] [hbase] virajjasani commented on a change in pull request #939: HBASE-23349 : Config based Scanner reset after compaction if low refCount is preventing archival of compacted away store files

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #939: HBASE-23349 : Config based Scanner reset after compaction if low refCount is preventing archival of compacted away store files
URL: https://github.com/apache/hbase/pull/939#discussion_r358965087
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
 ##########
 @@ -1202,5 +1322,24 @@ public void shipped() throws IOException {
       trySwitchToStreamRead();
     }
   }
+
+  final boolean checkIfScannersToBeReset() {
+    // to prevent volatile boolean scannersToBeReset lookup if
+    // isStoreFileForceArchivalEnabled is false already
+    if (!this.store.isStoreFileForceArchivalEnabled()) {
+      return false;
 
 Review comment:
   Here, we are trying to prevent volatile boolean lookup if the config `hbase.hstore.file.force.archive` is by default turned off.
   
   FYI @anoopsjohn @ramkrish86 @apurtell 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services