[GitHub] [hudi] danny0405 commented on a diff in pull request #6918: [HUDI-5006] Use the same wrapper for timestamp type metadata for parq…

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #6918:
URL: https://github.com/apache/hudi/pull/6918#discussion_r991866611


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -144,7 +144,7 @@ class ColumnStats {
 
         GenericRecord genericRecord = (GenericRecord) record;
 
-        final Object fieldVal = convertValueForSpecificDataTypes(field.schema(), genericRecord.get(field.name()), true);
+        final Object fieldVal = convertValueForSpecificDataTypes(field.schema(), genericRecord.get(field.name()), false);

Review Comment:
   Hi, @alexeykudinkin , can you take a look at this line, the change expects to work correctly right ? (same with parquet files, the parquet max/min for timestamp is the raw long, and we use a `LongWrapper` here).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org