You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/11 02:33:19 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #42445: [SPARK-44731][PYTHON][CONNECT] Make TimestampNTZ works with literals in Python Spark Connect
HyukjinKwon opened a new pull request, #42445:
URL: https://github.com/apache/spark/pull/42445
### What changes were proposed in this pull request?
This PR proposes:
- Share the namespaces for `to_timestamp_ntz`, `to_timestamp_ltz` and `to_unix_timestamp` in Spark Connect. They were missed.
- Adds the support of `TimestampNTZ` for literal handling in Python Spark Connect (by respecting `spark.sql.timestampType`).
### Why are the changes needed?
For feature parity, and respect timestamp ntz in resampling in pandas API on Spark
### Does this PR introduce _any_ user-facing change?
Yes, this virtually fixes the same bug: https://github.com/apache/spark/pull/42392 in Spark Connect with Python.
### How was this patch tested?
Unittests reenabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42445: [SPARK-44731][PYTHON][CONNECT] Make TimestampNTZ works with literals in Python Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42445:
URL: https://github.com/apache/spark/pull/42445#issuecomment-1674463632
merged to master and branch-3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42445: [SPARK-44731][PYTHON][CONNECT] Make TimestampNTZ works with literals in Python Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42445:
URL: https://github.com/apache/spark/pull/42445#issuecomment-1674146498
cc @attilapiros @ueshin @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42445: [SPARK-44731][PYTHON][CONNECT] Make TimestampNTZ works with literals in Python Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42445: [SPARK-44731][PYTHON][CONNECT] Make TimestampNTZ works with literals in Python Spark Connect
URL: https://github.com/apache/spark/pull/42445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org