You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2023/04/22 21:44:25 UTC
[GitHub] [solr] epugh opened a new pull request, #1581: SOLR-16761: Document the bin/solr api command
epugh opened a new pull request, #1581:
URL: https://github.com/apache/solr/pull/1581
https://issues.apache.org/jira/browse/SOLR-16761
# Description
I didn't know it existed..
# Solution
Bit o' docs.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #1581: SOLR-16761: Document the bin/solr api command
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #1581:
URL: https://github.com/apache/solr/pull/1581#discussion_r1175526020
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -73,6 +73,10 @@ Please refer to the https://solr.apache.org/downloads.html[Solr Downloads] site
=== Shard Management
* Solr now provides an xref:deployment-guide:shard-management.adoc#installshard[INSTALLSHARD] API to allow users who have built (per-shard) indices offline to import them into SolrCloud shards.
+== Solr 9.3
+=== Improvements to Solr CLI
+* the bin/solr -i and bin/solr -info removed in favour of bin/solr status command.
Review Comment:
```suggestion
=== Improvements to the Solr CLI
* The`-i` and `-info` options for `bin/solr` have been removed in favour of the `bin/solr status` command.
```
I think you added this to the wrong PR though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1581: SOLR-16761: Document the bin/solr api command
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1581:
URL: https://github.com/apache/solr/pull/1581#issuecomment-1518831010
As I opened this PR I wondered to myself, why do we have this command? Why not just use Curl etc? I'm curious if we have any ideas why this is here? For situations where you don't have curl???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1581: SOLR-16761: Document the bin/solr api command
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1581:
URL: https://github.com/apache/solr/pull/1581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1581: SOLR-16761: Document the bin/solr api command
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1581:
URL: https://github.com/apache/solr/pull/1581#discussion_r1175727653
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -73,6 +73,10 @@ Please refer to the https://solr.apache.org/downloads.html[Solr Downloads] site
=== Shard Management
* Solr now provides an xref:deployment-guide:shard-management.adoc#installshard[INSTALLSHARD] API to allow users who have built (per-shard) indices offline to import them into SolrCloud shards.
+== Solr 9.3
+=== Improvements to Solr CLI
+* the bin/solr -i and bin/solr -info removed in favour of bin/solr status command.
Review Comment:
argh.... How about I must merge this one ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1581: SOLR-16761: Document the bin/solr api command
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1581:
URL: https://github.com/apache/solr/pull/1581#issuecomment-1520478108
> As I opened this PR I wondered to myself, why do we have this command? Why not just use Curl etc? I'm curious if we have any ideas why this is here? For situations where you don't have curl???
There are a couple issues, like basicAuth and TLS I believe, that this makes much easier. (Though I have seen the command take extraordinary amounts of time to run. Like 5 seconds for a basic check that should take milliseconds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org